Re: [PATCH 25/49] perf/x86/rapl: Add support for Intel Alder Lake

From: kernel test robot <lkp@intel.com>
To: kan.liang@linux.intel.com, peterz@infradead.org, acme@kernel.org,
	mingo@kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	tglx@linutronix.de, bp@alien8.de, namhyung@kernel.org,
	jolsa@redhat.com, ak@linux.intel.com, yao.jin@linux.intel.com
Subject: Re: [PATCH 25/49] perf/x86/rapl: Add support for Intel Alder Lake
Date: Tue, 9 Feb 2021 13:16:36 +0800	[thread overview]
Message-ID: <202102091355.TVOnuOfY-lkp@intel.com> (raw)
In-Reply-To: <1612797946-18784-26-git-send-email-kan.liang@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 4670 bytes --]

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[cannot apply to tip/master linus/master tip/x86/core v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/kan-liang-linux-intel-com/Add-Alder-Lake-support-for-perf/20210209-070642
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 32451614da2a9cf4296f90d3606ac77814fb519d
config: x86_64-randconfig-a014-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/f02aa47253758867fa7f74a286fde01ed042ac42
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review kan-liang-linux-intel-com/Add-Alder-Lake-support-for-perf/20210209-070642
        git checkout f02aa47253758867fa7f74a286fde01ed042ac42
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/x86/events/rapl.c:804:2: error: use of undeclared identifier 'INTEL_FAM6_ALDERLAKE_L'
           X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L,         &model_skl),
           ^
   arch/x86/include/asm/cpu_device_id.h:161:39: note: expanded from macro 'X86_MATCH_INTEL_FAM6_MODEL'
           X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, INTEL_FAM6_##model, data)
                                                ^
   <scratch space>:149:1: note: expanded from here
   INTEL_FAM6_ALDERLAKE_L
   ^
   1 error generated.

vim +/INTEL_FAM6_ALDERLAKE_L +804 arch/x86/events/rapl.c

   772	
   773	static const struct x86_cpu_id rapl_model_match[] __initconst = {
   774		X86_MATCH_INTEL_FAM6_MODEL(SANDYBRIDGE,		&model_snb),
   775		X86_MATCH_INTEL_FAM6_MODEL(SANDYBRIDGE_X,	&model_snbep),
   776		X86_MATCH_INTEL_FAM6_MODEL(IVYBRIDGE,		&model_snb),
   777		X86_MATCH_INTEL_FAM6_MODEL(IVYBRIDGE_X,		&model_snbep),
   778		X86_MATCH_INTEL_FAM6_MODEL(HASWELL,		&model_hsw),
   779		X86_MATCH_INTEL_FAM6_MODEL(HASWELL_X,		&model_hsx),
   780		X86_MATCH_INTEL_FAM6_MODEL(HASWELL_L,		&model_hsw),
   781		X86_MATCH_INTEL_FAM6_MODEL(HASWELL_G,		&model_hsw),
   782		X86_MATCH_INTEL_FAM6_MODEL(BROADWELL,		&model_hsw),
   783		X86_MATCH_INTEL_FAM6_MODEL(BROADWELL_G,		&model_hsw),
   784		X86_MATCH_INTEL_FAM6_MODEL(BROADWELL_X,		&model_hsx),
   785		X86_MATCH_INTEL_FAM6_MODEL(BROADWELL_D,		&model_hsx),
   786		X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNL,	&model_knl),
   787		X86_MATCH_INTEL_FAM6_MODEL(XEON_PHI_KNM,	&model_knl),
   788		X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_L,		&model_skl),
   789		X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE,		&model_skl),
   790		X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X,		&model_hsx),
   791		X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L,		&model_skl),
   792		X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE,		&model_skl),
   793		X86_MATCH_INTEL_FAM6_MODEL(CANNONLAKE_L,	&model_skl),
   794		X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT,	&model_hsw),
   795		X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT_D,	&model_hsw),
   796		X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT_PLUS,	&model_hsw),
   797		X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_L,		&model_skl),
   798		X86_MATCH_INTEL_FAM6_MODEL(ICELAKE,		&model_skl),
   799		X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D,		&model_hsx),
   800		X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X,		&model_hsx),
   801		X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L,		&model_skl),
   802		X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE,		&model_skl),
   803		X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE,		&model_skl),
 > 804		X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L,		&model_skl),
   805		X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X,	&model_spr),
   806		X86_MATCH_VENDOR_FAM(AMD,	0x17,		&model_amd_fam17h),
   807		X86_MATCH_VENDOR_FAM(HYGON,	0x18,		&model_amd_fam17h),
   808		X86_MATCH_VENDOR_FAM(AMD,	0x19,		&model_amd_fam17h),
   809		{},
   810	};
   811	MODULE_DEVICE_TABLE(x86cpu, rapl_model_match);
   812	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37280 bytes --]