From: Rob Herring <robh@kernel.org>
To: Suman Anna <s-anna@ti.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: omap: Update binding for AM64x SoCs
Date: Tue, 9 Feb 2021 13:24:43 -0600 [thread overview]
Message-ID: <20210209192443.GA4192418@robh.at.kernel.org> (raw)
In-Reply-To: <20210127195600.23501-2-s-anna@ti.com>
On Wed, Jan 27, 2021 at 01:55:59PM -0600, Suman Anna wrote:
> Update the existing OMAP Mailbox binding to include the info for
> AM64x SoCs. There are some minor IP integration differences between
> the AM64x SoCs and the previous AM65x and J721E SoC families.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> .../bindings/mailbox/omap-mailbox.txt | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt
> index 5fe80c1c19fc..c993d1a5c14a 100644
> --- a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt
> +++ b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt
> @@ -28,6 +28,9 @@ SoCs has each of these instances form a cluster and combine multiple clusters
> into a single IP block present within the Main NavSS. The interrupt lines from
> all these clusters are multiplexed and routed to different processor subsystems
> over a limited number of common interrupt output lines of an Interrupt Router.
> +The AM64x SoCS also uses a single IP block comprising of multiple clusters,
> +but the number of clusters are smaller, and the interrupt output lines are
> +connected directly to various processors.
>
> Mailbox Device Node:
> ====================
> @@ -42,6 +45,7 @@ Required properties:
> "ti,omap4-mailbox" for OMAP44xx, OMAP54xx, AM33xx,
> AM43xx and DRA7xx SoCs
> "ti,am654-mailbox" for K3 AM65x and J721E SoCs
> + "ti,am64-mailbox" for K3 AM64x SoCs
> - reg: Contains the mailbox register address range (base
> address and length)
> - interrupts: Contains the interrupt information for the mailbox
> @@ -178,3 +182,21 @@ mailbox: mailbox@480c8000 {
> };
> };
> };
> +
> +4. /* AM64x */
> +&cbass_main {
Please don't add examples for just a new compatible.
> + mailbox0_cluster2: mailbox@29020000 {
> + compatible = "ti,am64-mailbox";
> + reg = <0x00 0x29020000 0x00 0x200>;
> + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> + #mbox-cells = <1>;
> + ti,mbox-num-users = <4>;
> + ti,mbox-num-fifos = <16>;
> +
> + mbox_main_r5fss0_core0: mbox-main-r5fss0-core0 {
> + ti,mbox-rx = <0 0 2>;
> + ti,mbox-tx = <1 0 2>;
> + };
> + };
> +};
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-02-09 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 19:55 [PATCH 0/2] Add Mailbox support for TI K3 AM64x SoCs Suman Anna
2021-01-27 19:55 ` [PATCH 1/2] dt-bindings: mailbox: omap: Update binding for " Suman Anna
2021-02-09 19:24 ` Rob Herring [this message]
2021-02-09 19:26 ` Suman Anna
2021-01-27 19:56 ` [PATCH 2/2] mailbox: omap: Add support for K3 " Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209192443.GA4192418@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).