From: Ira Weiny <ira.weiny@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls
Date: Tue, 9 Feb 2021 13:52:29 -0800 [thread overview]
Message-ID: <20210209215229.GC2975576@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20210209131103.b46e80db675fec8bec8d2ad1@linux-foundation.org>
On Tue, Feb 09, 2021 at 01:11:03PM -0800, Andrew Morton wrote:
> > >
> > > It would be best to merge [1/4] via the btrfs tree. Please add my
> > >
> > > Acked-by: Andrew Morton <akpm@linux-foundation.org>
> > >
> > >
> > > Although I think it would be better if [1/4] merely did the code
> > > movement. Adding those BUG_ON()s is a semantic/functional change and
> > > really shouldn't be bound up with the other things this patch series
> > > does.
> >
> > I proposed this too and was told 'no'...
> >
> > <quote>
> > If we put in into a separate patch, someone will suggest backing out the
> > patch which tells us that there's a problem.
> > </quote>
> > -- https://lore.kernel.org/lkml/20201209201415.GT7338@casper.infradead.org/
>
> Yeah, no, please let's not do this. Bundling an offtopic change into
> [1/4] then making three more patches dependent on the ontopic parts of
> [1/4] is just rude.
>
> I think the case for adding the BUG_ONs can be clearly made. And that
> case should at least have been clearly made in the [1/4] changelog!
>
> (Although I expect VM_BUG_ON() would be better - will give us sufficient
> coverage without the overall impact.)
I'm ok with VM_BUG_ON()
>
> Let's please queue this up separately.
Ok can I retain your Ack on the move part of the patch? Note that it does
change kmap_atomic() to kmap_local_page() currently.
Would you prefer a separate change for that as well?
Ira
PS really CC'ing Matthew now...
next prev parent reply other threads:[~2021-02-10 0:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 23:23 [PATCH 0/4] btrfs: Convert kmaps to core page calls ira.weiny
2021-02-05 23:23 ` [PATCH 1/4] mm/highmem: Lift memcpy_[to|from]_page to core ira.weiny
2021-02-07 1:46 ` Chaitanya Kulkarni
2021-02-08 3:13 ` Ira Weiny
2021-02-08 4:34 ` Chaitanya Kulkarni
2021-02-05 23:23 ` [PATCH 2/4] fs/btrfs: Use memcpy_[to|from]_page() ira.weiny
2021-02-09 15:14 ` David Sterba
2021-02-05 23:23 ` [PATCH 3/4] fs/btrfs: Use copy_highpage() instead of 2 kmaps() ira.weiny
2021-02-05 23:23 ` [PATCH 4/4] fs/btrfs: Convert to zero_user() ira.weiny
2021-02-09 15:11 ` [PATCH 0/4] btrfs: Convert kmaps to core page calls David Sterba
2021-02-09 17:45 ` Ira Weiny
2021-02-09 19:09 ` Andrew Morton
2021-02-09 20:52 ` Ira Weiny
2021-02-09 21:11 ` Andrew Morton
2021-02-09 21:52 ` Ira Weiny [this message]
2021-02-09 21:58 ` Andrew Morton
2021-02-09 22:03 ` Ira Weiny
2021-02-09 22:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209215229.GC2975576@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).