From: Dan Carpenter <dan.carpenter@oracle.com>
To: karthik alapati <mail@karthek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix block comments alignment
Date: Wed, 10 Feb 2021 10:27:17 +0300 [thread overview]
Message-ID: <20210210072717.GS2696@kadam> (raw)
In-Reply-To: <YCLaHXD/sUKM5HZE@karthik-strix-linux.karthek.com>
On Wed, Feb 10, 2021 at 12:23:17AM +0530, karthik alapati wrote:
> fix checkpatch.pl warning for "block comments should align the * on each line"
>
> Signed-off-by: karthik alapati <mail@karthek.com>
> ---
> .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +++++++++---------
> 1 file changed, 102 insertions(+), 102 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index cf23414d7..003f954c2 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -20,16 +20,16 @@
> #define MAX_DOZE_WAITING_TIMES_9x 64
>
> /**
> -* Function: phy_CalculateBitShift
> -*
> -* OverView: Get shifted position of the BitMask
> -*
> -* Input:
> -* u32 BitMask,
> -*
> -* Output: none
> -* Return: u32 Return the shift bit bit position of the mask
> -*/
> + * Function: phy_CalculateBitShift
> + *
> + * OverView: Get shifted position of the BitMask
> + *
> + * Input:
> + * u32 BitMask,
Why is this on a different line??
> + *
> + * Output: none
> + * Return: u32 Return the shift bit bit position of the mask
The "u32" is indented more than the "none". "bit bit" is probably a
typo?
> + */
> static u32 phy_CalculateBitShift(u32 BitMask)
> {
> u32 i;
There is a proper kernel-doc style that function comments are supposed
to use. https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html
./scripts/kernel-doc -v -none drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-10 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 18:53 [PATCH] staging: rtl8723bs: fix block comments alignment karthik alapati
2021-02-09 18:59 ` Greg Kroah-Hartman
[not found] ` <YCLd2286lLdO0BAE@karthik-strix-linux.karthek.com>
2021-02-09 19:17 ` karthek
2021-02-10 7:27 ` Dan Carpenter [this message]
2021-02-10 7:37 ` karthek
-- strict thread matches above, loose matches on Subject: below --
2021-02-07 14:16 karthek
2021-02-07 14:34 ` Greg Kroah-Hartman
[not found] ` <YB/9hS2S1oaCmuDq@karthik-strix-linux.karthek.com>
[not found] ` <YB//EZl0aeLk/y+E@kroah.com>
2021-02-07 15:11 ` karthek
2021-02-07 15:15 ` Greg Kroah-Hartman
2021-02-07 15:19 ` karthek
2021-02-07 15:21 ` Greg Kroah-Hartman
2021-02-07 15:24 ` karthek
2021-02-07 15:26 ` Greg Kroah-Hartman
2021-02-07 15:33 ` karthek
2021-02-09 16:20 ` karthek
2021-02-09 17:23 ` Greg Kroah-Hartman
2021-02-09 17:56 ` karthek
2021-02-09 18:49 ` Greg Kroah-Hartman
2021-02-09 18:52 ` karthek
2021-02-09 18:48 ` karthek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210072717.GS2696@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@karthek.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).