From: Amey Narkhede <ameynarkhede03@gmail.com>
To: gregkh@linuxfoundation.org, dan.carpenter@oracle.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Amey Narkhede <ameynarkhede03@gmail.com>
Subject: [PATCH v2] staging: gdm724x: Fix DMA from stack
Date: Wed, 10 Feb 2021 13:31:34 +0530 [thread overview]
Message-ID: <20210210080134.1978-1-ameynarkhede03@gmail.com> (raw)
Stack allocated buffers cannot be used for DMA
on all architectures so allocate hci_packet buffer
using kzalloc().
Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com>
---
Changes in v2:
- Fixed build warning
- Fixed memory leak using kfree
drivers/staging/gdm724x/gdm_usb.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
index dc4da66c3..c4a9b90c5 100644
--- a/drivers/staging/gdm724x/gdm_usb.c
+++ b/drivers/staging/gdm724x/gdm_usb.c
@@ -56,11 +56,15 @@ static int gdm_usb_recv(void *priv_dev,
static int request_mac_address(struct lte_udev *udev)
{
- u8 buf[16] = {0,};
- struct hci_packet *hci = (struct hci_packet *)buf;
+ u8 *buf;
+ struct hci_packet *hci;
struct usb_device *usbdev = udev->usbdev;
int actual;
int ret = -1;
+ buf = kzalloc(16, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+ hci = (struct hci_packet *)buf;
hci->cmd_evt = gdm_cpu_to_dev16(udev->gdm_ed, LTE_GET_INFORMATION);
hci->len = gdm_cpu_to_dev16(udev->gdm_ed, 1);
@@ -70,6 +74,7 @@ static int request_mac_address(struct lte_udev *udev)
&actual, 1000);
udev->request_mac_addr = 1;
+ kfree(buf);
return ret;
}
--
2.30.0
next reply other threads:[~2021-02-10 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 8:01 Amey Narkhede [this message]
2021-02-10 8:06 ` [PATCH v2] staging: gdm724x: Fix DMA from stack Greg KH
2021-02-10 8:58 ` Amey Narkhede
2021-02-10 9:04 ` Dan Carpenter
2021-02-10 10:48 ` Amey Narkhede
2021-02-10 9:09 ` Greg KH
2021-02-10 10:54 ` Amey Narkhede
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 19:31 ameynarkhede03
2021-02-09 19:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210080134.1978-1-ameynarkhede03@gmail.com \
--to=ameynarkhede03@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).