From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7252AC433E0 for ; Wed, 10 Feb 2021 09:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D68964E2F for ; Wed, 10 Feb 2021 09:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbhBJJM6 (ORCPT ); Wed, 10 Feb 2021 04:12:58 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:33172 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbhBJJCk (ORCPT ); Wed, 10 Feb 2021 04:02:40 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11A8xxGM117071; Wed, 10 Feb 2021 09:01:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=iP2G7L21Ok+LoC/Zq7zmu3BeQUif0cX4L5MAz+HUsL4=; b=hi2sSEb6FhJAOdIFyQDwN6KdlVXuQJFh+6one59/zV/i7f1LjDX+IrBHZXsW8u8c2Rxw Izvk6Yfrlvu+Ja8+SjaEMYi6asvII3vw/GdKUuLQ+tXFbJ6Yo2j9jCHpsugFRUNIGZvO Tv/YW3xzHiyrUNtQi02dPY+aSGnAztW3ZRQWbUZQ47U0fHGGyWp/jk2eRbtbT9h4xHKe yDxb7nSNGwQI16ec9t9m6ZxFHcfJw5v4/p/DDZX2ppyqlllwFoHvMsmzq0Rbct68NCyn 9MnRXjkGy3DJsSda6dRsx/KQqalh0uzrHFccqJCR9HjUozNJ2vKuL2hE53wrgbRbLy+3 jA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 36hkrn2f2a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Feb 2021 09:01:48 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11A916Va018572; Wed, 10 Feb 2021 09:01:46 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 36j51x9xuj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Feb 2021 09:01:46 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 11A91h8s023274; Wed, 10 Feb 2021 09:01:44 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 10 Feb 2021 01:01:42 -0800 Date: Wed, 10 Feb 2021 12:01:20 +0300 From: Dan Carpenter To: karthek Cc: Greg Kroah-Hartman , Stephen Rothwell , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc Message-ID: <20210210090120.GU20820@kadam> References: <20210210080636.GT2696@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9890 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102100092 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9890 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102100092 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 02:28:31PM +0530, karthek wrote: > On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter wrote: > > > @@ -789,7 +759,7 @@ static void phy_PostSetBwMode8723B(struct adapter *Adapter) > > > > > > PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x0); > > > > > > -/* PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 1); */ > > > + /*PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 1); */ > > > > This format is wrong. Anyway, just delete the commented out code. > > > > regards, > > dan carpenter > > > > how can i delete that, i have no idea what this driver does > i'm just fixing coding style issues for eudyptula challenge. > i dont think its a good idea to delete the code without knowing its > purpose even though its commented out Commented code obviously doesn't do anything at all? regards, dan carpenter