* [PATCH v1] x86/vdso: fix CE on non-compatible cflags
@ 2021-02-10 0:07 Tong Zhang
2021-02-10 9:36 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Tong Zhang @ 2021-02-10 0:07 UTC (permalink / raw)
To: Andy Lutomirski, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
x86, H. Peter Anvin, linux-kernel
Cc: ztong0001
I am getting some compilation error on when using CONFIG_X86_32 kernel
configuration
arch/x86/entry/vdso/vdso32/../vclock_gettime.c:29:1:
error: ‘-mindirect-branch’ and ‘-fcf-protection’ are not compatible
add -fcf-protection=none when CONFIG_RETPOLINE=y
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
arch/x86/entry/vdso/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index 02e3e42f380b..37885336b53f 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -159,6 +159,7 @@ KBUILD_CFLAGS_32 += -DDISABLE_BRANCH_PROFILING
ifdef CONFIG_RETPOLINE
ifneq ($(RETPOLINE_VDSO_CFLAGS),)
KBUILD_CFLAGS_32 += $(RETPOLINE_VDSO_CFLAGS)
+ KBUILD_CFLAGS_32 += $(call cc-option,-fcf-protection=none)
endif
endif
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] x86/vdso: fix CE on non-compatible cflags
2021-02-10 0:07 [PATCH v1] x86/vdso: fix CE on non-compatible cflags Tong Zhang
@ 2021-02-10 9:36 ` Borislav Petkov
2021-02-10 13:46 ` Tong Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2021-02-10 9:36 UTC (permalink / raw)
To: Tong Zhang
Cc: Andy Lutomirski, Thomas Gleixner, Ingo Molnar, x86,
H. Peter Anvin, linux-kernel
On Tue, Feb 09, 2021 at 07:07:49PM -0500, Tong Zhang wrote:
> I am getting some compilation error on when using CONFIG_X86_32 kernel
> configuration
With an ubuntu gcc?
Does this branch work:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/?h=x86/urgent
?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] x86/vdso: fix CE on non-compatible cflags
2021-02-10 9:36 ` Borislav Petkov
@ 2021-02-10 13:46 ` Tong Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Tong Zhang @ 2021-02-10 13:46 UTC (permalink / raw)
To: Borislav Petkov
Cc: Andy Lutomirski, Thomas Gleixner, Ingo Molnar, x86,
H. Peter Anvin, open list
Hi Borislav,
I am using ubuntu gcc, the x86-urgent branch works
Thanks,
- Tong
On Wed, Feb 10, 2021 at 4:36 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Tue, Feb 09, 2021 at 07:07:49PM -0500, Tong Zhang wrote:
> > I am getting some compilation error on when using CONFIG_X86_32 kernel
> > configuration
>
> With an ubuntu gcc?
> Does this branch work:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/?h=x86/urgent
>
> ?
>
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-10 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 0:07 [PATCH v1] x86/vdso: fix CE on non-compatible cflags Tong Zhang
2021-02-10 9:36 ` Borislav Petkov
2021-02-10 13:46 ` Tong Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).