From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C607C433E0 for ; Wed, 10 Feb 2021 11:46:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53D1B64DF6 for ; Wed, 10 Feb 2021 11:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbhBJLqM (ORCPT ); Wed, 10 Feb 2021 06:46:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbhBJLnB (ORCPT ); Wed, 10 Feb 2021 06:43:01 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F3AC061223 for ; Wed, 10 Feb 2021 03:42:07 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id u14so1560527wmq.4 for ; Wed, 10 Feb 2021 03:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IN+db2cORNt7VkGGcBYrI5DAOlBAd7luCiB6c6UTORg=; b=A+lqcb1Mco2IH4sWZvbvEORyp44FjHIA2kKgYhWKHPRcBkihslWgY+eyCxjObLl4xM IJdLu77vzz0H46AfAyGLrLZ3P1y6a5z1GwgMJhI4clGjeFf+PyAsCenM3g5U2vflKhew Ju+igjclW8aHFZvW5zgCxQyfWMS4Xu5pD9ywx63JFAYNlS4WSR6nbO70ZKcfoghRGb4z Rf0JtLIheyrZWr3WvWIiahz7R05/j8oqaJTIUkNIo+kjiEWRTPpEAZUcmb+bwwR3TthY w8gny9neoDuQOvARwJ0yj7al35enKLxoqYkPmwR0BkgrFFw+H8Knypppuo27DmWcolMY g6AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IN+db2cORNt7VkGGcBYrI5DAOlBAd7luCiB6c6UTORg=; b=TTK2W1MseoI3y0/rx9uiR1TE3wfyNHgjAaKxou+Lxt77BHAaD0fczCt10bila8ZRso jLHgy1noq44F+TKP7IC7sNGOUj9hmcA3h1U5Y9+wl9R2Z2fFO/97oEovKnxG7vxPZhk0 0jUqWBcrU5LYoePQjQeZTPOOrapV+5kZGv36bGiGRjqvdRDf7RuAH/bGVzP+uY2CmNK/ AoN41mlqM0/MPPfpaPEw0To7FaGjLofuDJIt5Bj1U55U3ct4UkJtiE52FBdG0hdpUDje O6Dk6J7bMuPE/UN67kgCXtNUjqQT35xNjCZo9csqVO8F4kaQPcjxGoewHzOjux1lYSai pTMg== X-Gm-Message-State: AOAM530YoI42kdAP4HLS913+zy9ChuAWRfoP3SIGMZWziomou3xnNxbH 8blfpV/X/zbOWEZDdz5vzLb3dw== X-Google-Smtp-Source: ABdhPJzcqeZvzBcu69WDOYa0AXEj+jkTjIK/0ivShR9A511clPVo2aBOAWDwimsl6o1C8uR6vnac8Q== X-Received: by 2002:a7b:c215:: with SMTP id x21mr2619209wmi.61.1612957326535; Wed, 10 Feb 2021 03:42:06 -0800 (PST) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id y63sm2154970wmd.21.2021.02.10.03.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 03:42:05 -0800 (PST) Date: Wed, 10 Feb 2021 11:42:03 +0000 From: Daniel Thompson To: Yicong Yang Cc: Greg KH , jdelvare@suse.com, linux@roeck-us.net, giometti@enneenne.com, abbotti@mev.co.uk, hsweeten@visionengravers.com, kw@linux.com, helgaas@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org, devel@driverdev.osuosl.org, linux-kbuild@vger.kernel.org, masahiroy@kernel.org, michal.lkml@markovi.net, linuxarm@openeuler.org, prime.zeng@huawei.com Subject: Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag Message-ID: <20210210114203.jvhst2veqbx73r5g@maple.lan> References: <1612518255-23052-1-git-send-email-yangyicong@hisilicon.com> <1612518255-23052-2-git-send-email-yangyicong@hisilicon.com> <08017751-a1be-ea07-50de-73d14ab6d57e@hisilicon.com> <1f0b2f37-db56-c220-dfe1-8c376031404f@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f0b2f37-db56-c220-dfe1-8c376031404f@hisilicon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote: > On 2021/2/8 18:47, Greg KH wrote: > > On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > >> On 2021/2/5 17:53, Greg KH wrote: > >>> What does this offer in benefit of the existing way? What is it fixing? > >>> Why do this "churn"? > >> > >> currently we have added ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG in the Makefile > >> of driver/base and driver/base/power, but not in the subdirectory > >> driver/base/firmware_loader. we cannot turn the debug on for subdirectory > >> firmware_loader if we config DEBUG_DRIVER and there is no kconfig option > >> for the it. > > > > Is that necessary? Does that directory need it? > > there are several debug prints in firmware_loader/main.c: > > ./main.c:207: pr_debug("%s: fw-%s fw_priv=%p\n", __func__, fw_name, fw_priv); > ./main.c:245: pr_debug("batched request - sharing the same struct fw_priv and lookup for multiple requests\n"); > Even if these are not in scope for CONFIG_DEBUG_DRVIER there is a config option that would allow you to observe them without changing any code (CONFIG_DYNAMIC_DEBUG). Daniel.