From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A81C433E0 for ; Wed, 10 Feb 2021 20:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F46364EDF for ; Wed, 10 Feb 2021 20:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232204AbhBJUKI (ORCPT ); Wed, 10 Feb 2021 15:10:08 -0500 Received: from mga07.intel.com ([134.134.136.100]:30166 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231642AbhBJUKE (ORCPT ); Wed, 10 Feb 2021 15:10:04 -0500 IronPort-SDR: IH8Ziy1k8mLsW16untHuT61yC+kunzqYcxH4sV1puAIQCJGhyTTgx3VvpOEhdSHWqhYNUK4yb1 sCa20AXAvbTA== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="246210597" X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="246210597" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 12:09:23 -0800 IronPort-SDR: +J1Kij01n+XrDgYX1SEFlvkGyh/OTLZW1LLUC+kRwgwbnA8ZqMddbIeh8YR2sypRmsNq+IXP4J lZVOi6moQIPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="510535168" Received: from lkp-server02.sh.intel.com (HELO cd560a204411) ([10.239.97.151]) by orsmga004.jf.intel.com with ESMTP; 10 Feb 2021 12:09:20 -0800 Received: from kbuild by cd560a204411 with local (Exim 4.92) (envelope-from ) id 1l9vnb-0003F7-MQ; Wed, 10 Feb 2021 20:09:19 +0000 Date: Thu, 11 Feb 2021 04:09:16 +0800 From: kernel test robot To: Brian Foster Cc: kbuild-all@lists.01.org, "Darrick J. Wong" , "Darrick J. Wong" , Allison Henderson , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] xfs: fix boolreturn.cocci warnings Message-ID: <20210210200916.GA96657@7319c0dab462> References: <202102110412.GVAOIBVp-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202102110412.GVAOIBVp-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task") CC: Brian Foster Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge head: 560ab6c0d12ebccabb83638abe23a7875b946f9a commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task xfs_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -1059,7 +1059,7 @@ xfs_log_need_covered( bool needed = false; if (!xlog_cil_empty(log)) - return 0; + return false; spin_lock(&log->l_icloglock); switch (log->l_covered_state) {