From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: "Paul J . Murphy" <paul.j.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Martina Krasteva <martinax.krasteva@intel.com>,
Gjorgji Rosikopulos <gjorgjix.rosikopulos@intel.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] media: i2c: imx334: Fix a read of the uninitialized variable ret
Date: Wed, 10 Feb 2021 23:03:03 +0200 [thread overview]
Message-ID: <20210210210303.GE3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210210190752.146631-1-colin.king@canonical.com>
Hi Colin,
On Wed, Feb 10, 2021 at 07:07:52PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there is a dev_err error message that is printing the
> error status in variable ret (that has not been set) instead of
> the correct error status from imx334->reset_gpio. Fix this.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 9746b11715c3 ("media: i2c: Add imx334 camera sensor driver")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/i2c/imx334.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
> index 07e31bc2ef18..f8b1caf26c9b 100644
> --- a/drivers/media/i2c/imx334.c
> +++ b/drivers/media/i2c/imx334.c
> @@ -790,7 +790,8 @@ static int imx334_parse_hw_config(struct imx334 *imx334)
> imx334->reset_gpio = devm_gpiod_get_optional(imx334->dev, "reset",
> GPIOD_OUT_LOW);
> if (IS_ERR(imx334->reset_gpio)) {
> - dev_err(imx334->dev, "failed to get reset gpio %d", ret);
> + dev_err(imx334->dev, "failed to get reset gpio %ld",
> + IS_ERR_VALUE(imx334->reset_gpio));
> return PTR_ERR(imx334->reset_gpio);
> }
Thanks for the patch. This has been already addressed by another patch
here, and has just been applied to linux-media master.
commit c702e2f70275dbc5373aef50c450cf9c5730636c
Author: Hans Verkuil <hverkuil@xs4all.nl>
Date: Mon Feb 8 12:32:29 2021 +0100
media: imx334: 'ret' is uninitialized, should have been PTR_ERR()
Fix this compiler warning:
drivers/media/i2c/imx334.c: In function 'imx334_parse_hw_config':
include/linux/dev_printk.h:112:2: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~
drivers/media/i2c/imx334.c:783:6: note: 'ret' was declared here
783 | int ret;
| ^~~
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-02-10 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:07 [PATCH][next] media: i2c: imx334: Fix a read of the uninitialized variable ret Colin King
2021-02-10 21:03 ` Sakari Ailus [this message]
2021-02-11 10:41 ` Dan Carpenter
2021-02-11 10:50 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210210303.GE3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=daniele.alessandrelli@intel.com \
--cc=gjorgjix.rosikopulos@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martinax.krasteva@intel.com \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).