From: Ira Weiny <ira.weiny@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Sterba <dsterba@suse.cz>,
clm@fb.com, josef@toxicpanda.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls
Date: Wed, 10 Feb 2021 13:22:28 -0800 [thread overview]
Message-ID: <20210210212228.GF3014244@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20210210185606.GF308988@casper.infradead.org>
On Wed, Feb 10, 2021 at 06:56:06PM +0000, Matthew Wilcox wrote:
> On Wed, Feb 10, 2021 at 08:29:01AM -0800, Ira Weiny wrote:
> > And I thought it was a good idea. Any file system development should have
> > tests with DEBUG_VM which should cover Matthew's concern while not having the
> > overhead in production. Seemed like a decent compromise?
>
> Why do you think these paths are only used during file system development?
I can't guarantee it but right now most of the conversions I have worked on are
in FS's.
> They're definitely used by networking, by device drivers of all kinds
> and they're probably even used by the graphics system.
>
> While developers *should* turn on DEBUG_VM during development, a
> shockingly high percentage don't even turn on lockdep.
Honestly, I don't feel strongly enough to argue it.
Andrew? David? David this is going through your tree so would you feel more
comfortable with 1 or the other?
Ira
next prev parent reply other threads:[~2021-02-10 21:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 6:22 [PATCH V2 0/8] btrfs: convert kmaps to core page calls ira.weiny
2021-02-10 6:22 ` [PATCH V2 1/8] mm/highmem: Lift memcpy_[to|from]_page to core ira.weiny
2021-02-10 6:33 ` Chaitanya Kulkarni
2021-02-10 12:53 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 2/8] mm/highmem: Convert memcpy_[to|from]_page() to kmap_local_page() ira.weiny
2021-02-10 6:37 ` Chaitanya Kulkarni
2021-02-10 12:54 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 3/8] mm/highmem: Introduce memcpy_page(), memmove_page(), and memset_page() ira.weiny
2021-02-10 6:46 ` Chaitanya Kulkarni
2021-02-10 12:54 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls ira.weiny
2021-02-10 6:57 ` Chaitanya Kulkarni
2021-02-10 16:31 ` Ira Weiny
2021-02-10 12:55 ` Christoph Hellwig
2021-02-10 16:29 ` Ira Weiny
2021-02-10 16:41 ` Christoph Hellwig
2021-02-10 17:04 ` Ira Weiny
2021-02-10 18:56 ` Matthew Wilcox
2021-02-10 21:22 ` Ira Weiny [this message]
2021-02-11 18:52 ` David Sterba
2021-02-10 17:49 ` [PATCH V2.1] " ira.weiny
2021-02-10 6:22 ` [PATCH V2 5/8] iov_iter: Remove memzero_page() in favor of zero_user() ira.weiny
2021-02-10 12:55 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 6/8] btrfs: use memcpy_[to|from]_page() and kmap_local_page() ira.weiny
2021-02-10 12:56 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 7/8] btrfs: use copy_highpage() instead of 2 kmaps() ira.weiny
2021-02-10 12:56 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 8/8] btrfs: convert to zero_user() ira.weiny
2021-02-10 12:57 ` Christoph Hellwig
2021-02-11 19:38 ` [PATCH V2 0/8] btrfs: convert kmaps to core page calls David Sterba
2021-02-11 21:32 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210212228.GF3014244@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).