From: Michael Walle <michael@walle.cc>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Michael Walle <michael@walle.cc>
Subject: [PATCH net-next v4 2/9] net: phy: icplus: use PHY_ID_MATCH_EXACT() for IP101A/G
Date: Thu, 11 Feb 2021 08:47:43 +0100 [thread overview]
Message-ID: <20210211074750.28674-3-michael@walle.cc> (raw)
In-Reply-To: <20210211074750.28674-1-michael@walle.cc>
According to the datasheet of the IP101A/G there is no revision field
and MII_PHYSID2 always reads as 0x0c54. Use PHY_ID_MATCH_EXACT() then.
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
Changes since v3:
- none
Changes since v2:
- none
Changes since v1:
- none
drivers/net/phy/icplus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/icplus.c b/drivers/net/phy/icplus.c
index 4407b1eb1a3d..ae3cf61c5ac2 100644
--- a/drivers/net/phy/icplus.c
+++ b/drivers/net/phy/icplus.c
@@ -349,7 +349,7 @@ static struct phy_driver icplus_driver[] = {
.suspend = genphy_suspend,
.resume = genphy_resume,
}, {
- PHY_ID_MATCH_MODEL(IP101A_PHY_ID),
+ PHY_ID_MATCH_EXACT(IP101A_PHY_ID),
.name = "ICPlus IP101A/G",
/* PHY_BASIC_FEATURES */
.probe = ip101a_g_probe,
@@ -365,7 +365,7 @@ module_phy_driver(icplus_driver);
static struct mdio_device_id __maybe_unused icplus_tbl[] = {
{ PHY_ID_MATCH_MODEL(IP175C_PHY_ID) },
{ PHY_ID_MATCH_MODEL(IP1001_PHY_ID) },
- { PHY_ID_MATCH_MODEL(IP101A_PHY_ID) },
+ { PHY_ID_MATCH_EXACT(IP101A_PHY_ID) },
{ }
};
--
2.20.1
next prev parent reply other threads:[~2021-02-11 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 7:47 [PATCH net-next v4 0/9] net: phy: icplus: cleanups and new features Michael Walle
2021-02-11 7:47 ` [PATCH net-next v4 1/9] net: phy: icplus: use PHY_ID_MATCH_MODEL() macro Michael Walle
2021-02-11 7:47 ` Michael Walle [this message]
2021-02-11 7:47 ` [PATCH net-next v4 3/9] net: phy: icplus: drop address operator for functions Michael Walle
2021-02-11 7:47 ` [PATCH net-next v4 4/9] net: phy: icplus: use the .soft_reset() of the phy-core Michael Walle
2021-02-11 7:47 ` [PATCH net-next v4 5/9] net: phy: icplus: split IP101A/G driver Michael Walle
2021-02-11 7:47 ` [PATCH net-next v4 6/9] net: phy: icplus: don't set APS_EN bit on IP101G Michael Walle
2021-02-11 7:47 ` [PATCH net-next v4 7/9] net: phy: icplus: fix paged register access Michael Walle
2021-02-11 7:47 ` [PATCH net-next v4 8/9] net: phy: icplus: add PHY counter for IP101G Michael Walle
2021-02-11 7:47 ` [PATCH net-next v4 9/9] net: phy: icplus: add MDI/MDIX support for IP101A/G Michael Walle
2021-02-11 22:10 ` [PATCH net-next v4 0/9] net: phy: icplus: cleanups and new features patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211074750.28674-3-michael@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).