From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: irq: Fix the return value for of_irq_parse_one() stub
Date: Thu, 11 Feb 2021 08:09:36 +1100 [thread overview]
Message-ID: <20210211080936.7c51b99c@canb.auug.org.au> (raw)
In-Reply-To: <20210210200050.4106032-1-saravanak@google.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
Hi Saravana,
On Wed, 10 Feb 2021 12:00:49 -0800 Saravana Kannan <saravanak@google.com> wrote:
>
> When commit 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()")
> added a stub for of_irq_parse_one() it set the return value to 0. Return
> value of 0 in this instance means the call succeeded and the out_irq
> pointer was filled with valid data. So, fix it to return an error value.
>
> Fixes: 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()")
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Oops, sorry about that.
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-02-10 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 20:00 [PATCH] of: irq: Fix the return value for of_irq_parse_one() stub Saravana Kannan
2021-02-10 21:09 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211080936.7c51b99c@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).