From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14011C433DB for ; Thu, 11 Feb 2021 18:05:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D41C964DE0 for ; Thu, 11 Feb 2021 18:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232627AbhBKR5G (ORCPT ); Thu, 11 Feb 2021 12:57:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbhBKRWH (ORCPT ); Thu, 11 Feb 2021 12:22:07 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 633CCC0613D6 for ; Thu, 11 Feb 2021 09:21:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4V4RhiH1UyWnF1PtklR0TeZu/LJmoRUY68pmD70X6pg=; b=cm8aslEvrbI3fGlEgYmSPP8j/o WtSGBsoo62PW5j/jduzHluCay3av4lz54ilWJi90oqNk8xxskPcWev3AEzQp77bvGbtMpSou1aOda j07498Ev5uESzoV2FaYlmfhqw7K4qIKaWCdmUo/pNitPPeodqmJcG+gE1KAUQGFooIKZobtklFmTH 5NwPLy0xUwmYHNXNWHujRt2do1DsDv5DyS19YFOTipD+761Blrg6Jf/baKTxiwILgY0OUGXhnWAsQ AEzlASSpqtpSW6Bjae5cmxNTgFHiNbyRO+h1PUz1tWxBTtUxKxMbvGQ/5FW44z+4L/LMqXZYaSBqv E9og+bnw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lAFdi-00AWc0-SA; Thu, 11 Feb 2021 17:20:28 +0000 Date: Thu, 11 Feb 2021 17:20:26 +0000 From: Matthew Wilcox To: Timur Tabi Cc: Pavel Machek , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Vlastimil Babka , Andy Shevchenko , akpm@linux-foundation.org, Linus Torvalds , roman.fietze@magna.com, Kees Cook , John Ogness , akinobu.mita@gmail.com, glider@google.com, Andrey Konovalov , Marco Elver , Rasmus Villemoes , Tetsuo Handa , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed Message-ID: <20210211172026.GL308988@casper.infradead.org> References: <20210210213453.1504219-1-timur@kernel.org> <20210210213453.1504219-4-timur@kernel.org> <20210211123118.GB31708@amd> <9f0c02d9-29d6-95ce-b9b7-27342aa70c6f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f0c02d9-29d6-95ce-b9b7-27342aa70c6f@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 11:08:12AM -0600, Timur Tabi wrote: > > > On 2/11/21 6:31 AM, Pavel Machek wrote: > > Can we make this something shorter? Clearly you don't want people > > placing this in their grub config, so they'll be most likely typing > > this a lot... > > > > debug_pointers or debug_ptrs would be better. > > dbg_unhash_ptrs? "debug_ptrs" is too vague IMHO, and I want to keep the > word "hash" somewhere there to indicate exactly what's happening. no_hash_pointers ?