From: Ira Weiny <ira.weiny@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Sterba <dsterba@suse.cz>,
David Howells <dhowells@redhat.com>,
David Sterba <dsterba@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the btrfs tree with the fscache tree
Date: Thu, 11 Feb 2021 17:07:41 -0800 [thread overview]
Message-ID: <20210212010740.GP3014244@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20210212103810.170b93e8@canb.auug.org.au>
On Fri, Feb 12, 2021 at 10:38:10AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the btrfs tree got a conflict in:
>
> lib/iov_iter.c
>
> between commit:
>
> 11432a3cc061 ("iov_iter: Add ITER_XARRAY")
>
> from the fscache tree and commit:
>
> 325a835476e3 ("iov_iter: Remove memzero_page() in favor of zero_user()")
I don't seem to have that commit after fetching linux-next? Should I have it?
This is where I fetched from.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
After doing that I don't see the zero_user() as below.
All that said the resolution below seems correct.
Ira
>
> from the btrfs tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc lib/iov_iter.c
> index 24413884b5ca,aa0d03b33a1e..000000000000
> --- a/lib/iov_iter.c
> +++ b/lib/iov_iter.c
> @@@ -1048,9 -961,8 +1028,9 @@@ size_t iov_iter_zero(size_t bytes, stru
> return pipe_zero(bytes, i);
> iterate_and_advance(i, bytes, v,
> clear_user(v.iov_base, v.iov_len),
> - memzero_page(v.bv_page, v.bv_offset, v.bv_len),
> + zero_user(v.bv_page, v.bv_offset, v.bv_len),
> - memset(v.iov_base, 0, v.iov_len)
> + memset(v.iov_base, 0, v.iov_len),
> - memzero_page(v.bv_page, v.bv_offset, v.bv_len)
> ++ zero_user(v.bv_page, v.bv_offset, v.bv_len)
> )
>
> return bytes;
next prev parent reply other threads:[~2021-02-12 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 23:38 linux-next: manual merge of the btrfs tree with the fscache tree Stephen Rothwell
2021-02-12 1:07 ` Ira Weiny [this message]
2021-02-12 3:04 ` Stephen Rothwell
2021-02-17 23:50 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212010740.GP3014244@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).