From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED20CC433DB for ; Fri, 12 Feb 2021 10:51:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCC9964DCD for ; Fri, 12 Feb 2021 10:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbhBLKv2 (ORCPT ); Fri, 12 Feb 2021 05:51:28 -0500 Received: from 8bytes.org ([81.169.241.247]:55646 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbhBLKvW (ORCPT ); Fri, 12 Feb 2021 05:51:22 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id D2EDC310; Fri, 12 Feb 2021 11:50:40 +0100 (CET) Date: Fri, 12 Feb 2021 11:50:39 +0100 From: Joerg Roedel To: Sai Prakash Ranjan Cc: Will Deacon , Robin Murphy , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] iommu: Add device name to iommu map/unmap trace events Message-ID: <20210212105039.GG7302@8bytes.org> References: <20210209123620.19993-1-saiprakash.ranjan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209123620.19993-1-saiprakash.ranjan@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 06:06:20PM +0530, Sai Prakash Ranjan wrote: > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 5e7fe519430a..6064187d9bb6 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -87,6 +87,7 @@ struct iommu_domain { > void *handler_token; > struct iommu_domain_geometry geometry; > void *iova_cookie; > + char dev_name[32]; > }; No, definitly not. A domain is a device DMA address space which can be used by more than one device. Just look at IOMMU groups with more than one member device, in this case just one device name would be very misleading. Regards, Joerg