From: Steven Rostedt <rostedt@goodmis.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Xi Ruoyao <xry111@mengyan1223.wang>,
"# 3.4.x" <stable@vger.kernel.org>,
Arnd Bergmann <arnd@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Miroslav Benes <mbenes@suse.cz>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols
Date: Fri, 12 Feb 2021 12:45:47 -0500 [thread overview]
Message-ID: <20210212124547.1dcf067e@gandalf.local.home> (raw)
In-Reply-To: <20210212170750.y7xtitigfqzpchqd@treble>
On Fri, 12 Feb 2021 11:07:50 -0600
Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > Any ideas are appreciated.
>
> [ Adding Steve Rostedt ]
>
> This error message comes from recordmcount. It probably can't handle
> the missing STT_SECTION symbols which are getting stripped by the new
> binutils. (Objtool also had trouble with that.)
>
> No idea why you only see this on 4.4 though.
>
Just taking a quick look, but would something like this work?
I created this against v4.4.257.
-- Steve
diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
index 04151ede8043..698404f092d0 100644
--- a/scripts/recordmcount.h
+++ b/scripts/recordmcount.h
@@ -437,6 +437,8 @@ static unsigned find_secsym_ndx(unsigned const txtndx,
if (w2(ehdr->e_machine) == EM_ARM
&& ELF_ST_TYPE(symp->st_info) == STT_FUNC)
continue;
+ if (ELF_ST_TYPE(symp->st_info) == STT_SECTION)
+ continue;
*recvalp = _w(symp->st_value);
return symp - sym0;
next prev parent reply other threads:[~2021-02-12 17:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 22:04 [PATCH] objtool: Fix seg fault with Clang non-section symbols Josh Poimboeuf
2020-12-16 12:48 ` Miroslav Benes
2020-12-16 13:49 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2021-02-11 13:32 ` Xi Ruoyao
2021-02-11 13:55 ` Greg Kroah-Hartman
2021-02-11 18:46 ` Nick Desaulniers
2021-02-12 9:40 ` Xi Ruoyao
2021-02-12 15:30 ` Greg Kroah-Hartman
2021-02-12 17:07 ` Josh Poimboeuf
2021-02-12 17:45 ` Steven Rostedt [this message]
2021-02-13 14:09 ` Greg Kroah-Hartman
2021-02-13 14:13 ` Steven Rostedt
2021-02-13 15:52 ` Josh Poimboeuf
2021-02-13 16:25 ` Greg Kroah-Hartman
2021-02-14 15:51 ` Josh Poimboeuf
2021-02-15 14:53 ` Steven Rostedt
2021-02-15 15:58 ` Josh Poimboeuf
2021-02-15 21:22 ` Steven Rostedt
2021-02-13 13:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212124547.1dcf067e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).