Re: [PATCH 1/2] quota: Add mountpath based quota support

From: kernel test robot <lkp@intel.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, linux-fsdevel@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	kernel@pengutronix.de, Jan Kara <jack@suse.com>,
	Richard Weinberger <richard@nod.at>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 1/2] quota: Add mountpath based quota support
Date: Fri, 12 Feb 2021 13:45:12 +0800	[thread overview]
Message-ID: <202102121329.4Up8otOd-lkp@intel.com> (raw)
In-Reply-To: <20210211153024.32502-2-s.hauer@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 3017 bytes --]

Hi Sascha,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on tip/x86/asm m68k/for-next hp-parisc/for-next powerpc/next s390/features linus/master v5.11-rc7 next-20210211]
[cannot apply to sparc/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sascha-Hauer/quota-Add-mountpath-based-quota-support/20210211-233912
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: x86_64-randconfig-a012-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/4b7a3df11dd2ca215a6e9b24d81c98d6951476b6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sascha-Hauer/quota-Add-mountpath-based-quota-support/20210211-233912
        git checkout 4b7a3df11dd2ca215a6e9b24d81c98d6951476b6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> fs/quota/quota.c:995:6: error: implicit declaration of function 'quotactl_cmd_write' [-Werror,-Wimplicit-function-declaration]
           if (quotactl_cmd_write(cmds)) {
               ^
   fs/quota/quota.c:995:6: note: did you mean 'quotactl_cmd_onoff'?
   fs/quota/quota.c:857:13: note: 'quotactl_cmd_onoff' declared here
   static bool quotactl_cmd_onoff(int cmd)
               ^
   1 error generated.

vim +/quotactl_cmd_write +995 fs/quota/quota.c

   972	
   973	SYSCALL_DEFINE4(quotactl_path, unsigned int, cmd, const char __user *,
   974			mountpoint, qid_t, id, void __user *, addr)
   975	{
   976		struct super_block *sb;
   977		struct path mountpath;
   978		unsigned int cmds = cmd >> SUBCMDSHIFT;
   979		unsigned int type = cmd & SUBCMDMASK;
   980		int ret;
   981	
   982		if (type >= MAXQUOTAS)
   983			return -EINVAL;
   984	
   985		if (!mountpoint)
   986			return -ENODEV;
   987	
   988		ret = user_path_at(AT_FDCWD, mountpoint,
   989				     LOOKUP_FOLLOW | LOOKUP_AUTOMOUNT, &mountpath);
   990		if (ret)
   991			return ret;
   992	
   993		sb = mountpath.dentry->d_inode->i_sb;
   994	
 > 995		if (quotactl_cmd_write(cmds)) {

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34205 bytes --]