From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: sgoutham@marvell.com, cjacob@marvell.com, gakula@marvell.com,
sbhatta@marvell.com, hkelam@marvell.com, kuba@kernel.org,
jesse.brandeburg@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get_fecparam()
Date: Mon, 15 Feb 2021 12:57:33 -0800 (PST) [thread overview]
Message-ID: <20210215.125733.311587463365048945.davem@davemloft.net> (raw)
In-Reply-To: <YCqZvjAzSmJk5Ftb@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 15 Feb 2021 18:56:46 +0300
> The "<= FEC_MAX_INDEX" comparison should be "< FEC_MAX_INDEX".
>
> I did some cleanup in this function to hopefully make the code a bit
> clearer. There was no blank line after the declaration block. The
> closing curly brace on the fec[] declaration normally goes on a line
> by itself. And I removed the FEC_MAX_INDEX define and used
> ARRAY_SIZE(fec) instead.
>
> Fixes: d0cf9503e908 ("octeontx2-pf: ethtool fec mode support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This doesn't apply to net-next.
prev parent reply other threads:[~2021-02-15 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:56 [PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get_fecparam() Dan Carpenter
2021-02-15 20:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215.125733.311587463365048945.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cjacob@marvell.com \
--cc=dan.carpenter@oracle.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jesse.brandeburg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).