From: "Mickaël Salaün" <mic@digikod.net>
To: James Morris <jmorris@namei.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"Serge E . Hallyn" <serge@hallyn.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Nicolas Iooss" <nicolas.iooss@m4x.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Mickaël Salaün" <mic@linux.microsoft.com>
Subject: [PATCH v1 1/3] kconfig: Remove duplicate call to sym_get_string_value()
Date: Mon, 15 Feb 2021 13:25:11 +0100 [thread overview]
Message-ID: <20210215122513.1773897-2-mic@digikod.net> (raw)
In-Reply-To: <20210215122513.1773897-1-mic@digikod.net>
From: Mickaël Salaün <mic@linux.microsoft.com>
Use the saved returned value of sym_get_string_value() instead of
calling it twice.
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
Link: https://lore.kernel.org/r/20210215122513.1773897-2-mic@digikod.net
---
scripts/kconfig/conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index db03e2f45de4..18a233d27a8d 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -137,7 +137,7 @@ static int conf_string(struct menu *menu)
printf("%*s%s ", indent - 1, "", menu->prompt->text);
printf("(%s) ", sym->name);
def = sym_get_string_value(sym);
- if (sym_get_string_value(sym))
+ if (def)
printf("[%s] ", def);
if (!conf_askvalue(sym, def))
return 0;
--
2.30.0
next prev parent reply other threads:[~2021-02-15 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 12:25 [PATCH v1 0/3] Kconfig oldconfig string update Mickaël Salaün
2021-02-15 12:25 ` Mickaël Salaün [this message]
2021-02-15 12:25 ` [PATCH v1 2/3] kconfig: Ask user if string needs to be changed when dependency changed Mickaël Salaün
2021-02-15 14:13 ` Boris Kolpackov
2021-02-15 15:40 ` Mickaël Salaün
2021-02-15 12:25 ` [PATCH v1 3/3] security: Add LSMs dependencies to CONFIG_LSM Mickaël Salaün
2021-02-15 17:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215122513.1773897-2-mic@digikod.net \
--to=mic@digikod.net \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mic@linux.microsoft.com \
--cc=nicolas.iooss@m4x.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).