From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62EC7C433E6 for ; Mon, 15 Feb 2021 17:47:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D09964DDA for ; Mon, 15 Feb 2021 17:47:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232248AbhBORrp (ORCPT ); Mon, 15 Feb 2021 12:47:45 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:45605 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232733AbhBORd2 (ORCPT ); Mon, 15 Feb 2021 12:33:28 -0500 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 0C6B3100002; Mon, 15 Feb 2021 17:32:32 +0000 (UTC) Date: Mon, 15 Feb 2021 18:32:32 +0100 From: Alexandre Belloni To: Steen Hegelund Cc: Philipp Zabel , Rob Herring , Andrew Lunn , Microchip Linux Driver Support , Gregory Clement , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Message-ID: <20210215173232.GM6798@piout.net> References: <20210210091952.2013027-1-steen.hegelund@microchip.com> <20210210091952.2013027-2-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210091952.2013027-2-steen.hegelund@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/2021 10:19:50+0100, Steen Hegelund wrote: > Document the Sparx5 reset device driver bindings > > The driver uses two IO ranges on sparx5 for access to > the reset control and the reset status. > > Signed-off-by: Steen Hegelund > --- > .../bindings/reset/microchip,rst.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/microchip,rst.yaml > > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > new file mode 100644 > index 000000000000..80046172c9f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/reset/microchip,rst.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Microchip Sparx5 Switch Reset Controller > + > +maintainers: > + - Steen Hegelund > + - Lars Povlsen > + > +description: | > + The Microchip Sparx5 Switch provides reset control and implements the following > + functions > + - One Time Switch Core Reset (Soft Reset) > + > +properties: > + $nodename: > + pattern: "^reset-controller@[0-9a-f]+$" > + > + compatible: > + const: microchip,sparx5-switch-reset > + > + reg: > + items: > + - description: cpu block registers > + - description: global control block registers > + > + reg-names: > + items: > + - const: cpu > + - const: gcb > + I still think this is not right because then you will be mapping the same set of register using multiple drivers without any form of synchronisation which will work because you are mapping the region without requesting it. But this may lead to issues later. At least, you should make cpu start at 0x80 and of size 4. Else, you won't be able to define and use the GPRs that are in front of CPU_REGS:RESET. I would still keep DEVCPU_GCB:CHIP_REGS as a syscon, especially since you are mapping the whole set of registers. > + "#reset-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - "#reset-cells" > + > +additionalProperties: false > + > +examples: > + - | > + reset: reset-controller@0 { > + compatible = "microchip,sparx5-switch-reset"; > + #reset-cells = <1>; > + reg = <0x0 0xd0>, > + <0x11010000 0x10000>; > + reg-names = "cpu", "gcb"; > + }; > + > -- > 2.30.0 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com