* [PATCH 0/1] fix machine_kexec_post_load prototype.
@ 2021-02-15 18:59 Pavel Tatashin
2021-02-15 18:59 ` [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface Pavel Tatashin
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Tatashin @ 2021-02-15 18:59 UTC (permalink / raw)
To: pasha.tatashin, linux-arm-kernel, jmorris, linux-kernel, tyhicks,
will, james.morse, ebiederm, kexec
This is against for-next/kexec, fix for machine_kexec_post_load
warning.
Reported by kernel test robot [1].
[1] https://lore.kernel.org/linux-arm-kernel/202102030727.gqTokACH-lkp@intel.com
Pavel Tatashin (1):
kexec: move machine_kexec_post_load() to public interface
include/linux/kexec.h | 2 ++
kernel/kexec_internal.h | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface
2021-02-15 18:59 [PATCH 0/1] fix machine_kexec_post_load prototype Pavel Tatashin
@ 2021-02-15 18:59 ` Pavel Tatashin
2021-02-19 17:53 ` Will Deacon
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Tatashin @ 2021-02-15 18:59 UTC (permalink / raw)
To: pasha.tatashin, linux-arm-kernel, jmorris, linux-kernel, tyhicks,
will, james.morse, ebiederm, kexec
machine_kexec_post_load() is called after kexec load is finished. It must
be declared in public header not in kexec_internal.h
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
---
include/linux/kexec.h | 2 ++
kernel/kexec_internal.h | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index 9e93bef52968..3671b845cf28 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -309,6 +309,8 @@ extern void machine_kexec_cleanup(struct kimage *image);
extern int kernel_kexec(void);
extern struct page *kimage_alloc_control_pages(struct kimage *image,
unsigned int order);
+int machine_kexec_post_load(struct kimage *image);
+
extern void __crash_kexec(struct pt_regs *);
extern void crash_kexec(struct pt_regs *);
int kexec_should_crash(struct task_struct *);
diff --git a/kernel/kexec_internal.h b/kernel/kexec_internal.h
index 39d30ccf8d87..48aaf2ac0d0d 100644
--- a/kernel/kexec_internal.h
+++ b/kernel/kexec_internal.h
@@ -13,8 +13,6 @@ void kimage_terminate(struct kimage *image);
int kimage_is_destination_range(struct kimage *image,
unsigned long start, unsigned long end);
-int machine_kexec_post_load(struct kimage *image);
-
extern struct mutex kexec_mutex;
#ifdef CONFIG_KEXEC_FILE
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface
2021-02-15 18:59 ` [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface Pavel Tatashin
@ 2021-02-19 17:53 ` Will Deacon
2021-02-19 19:06 ` Pavel Tatashin
0 siblings, 1 reply; 6+ messages in thread
From: Will Deacon @ 2021-02-19 17:53 UTC (permalink / raw)
To: Pavel Tatashin
Cc: linux-arm-kernel, jmorris, linux-kernel, tyhicks, james.morse,
ebiederm, kexec
On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote:
> machine_kexec_post_load() is called after kexec load is finished. It must
> be declared in public header not in kexec_internal.h
Could you provide a log of what goes wrong without this patch, please?
> Reported-by: kernel test robot <lkp@intel.com>
Do you have a link to the report, or did it not go to the list?
Will
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface
2021-02-19 17:53 ` Will Deacon
@ 2021-02-19 19:06 ` Pavel Tatashin
2021-02-19 19:14 ` Will Deacon
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Tatashin @ 2021-02-19 19:06 UTC (permalink / raw)
To: Will Deacon
Cc: Linux ARM, James Morris, LKML, Tyler Hicks, James Morse,
Eric W. Biederman, kexec mailing list
On Fri, Feb 19, 2021 at 12:53 PM Will Deacon <will@kernel.org> wrote:
>
> On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote:
> > machine_kexec_post_load() is called after kexec load is finished. It must
> > be declared in public header not in kexec_internal.h
>
> Could you provide a log of what goes wrong without this patch, please?
>
> > Reported-by: kernel test robot <lkp@intel.com>
>
> Do you have a link to the report, or did it not go to the list?
Hi Will,
https://lore.kernel.org/linux-arm-kernel/202102030727.gqTokACH-lkp@intel.com/
It is also linked in the cover letter.
Thank you,
Pasha
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface
2021-02-19 19:06 ` Pavel Tatashin
@ 2021-02-19 19:14 ` Will Deacon
2021-02-19 19:53 ` Pavel Tatashin
0 siblings, 1 reply; 6+ messages in thread
From: Will Deacon @ 2021-02-19 19:14 UTC (permalink / raw)
To: Pavel Tatashin
Cc: Linux ARM, James Morris, LKML, Tyler Hicks, James Morse,
Eric W. Biederman, kexec mailing list
On Fri, Feb 19, 2021 at 02:06:31PM -0500, Pavel Tatashin wrote:
> On Fri, Feb 19, 2021 at 12:53 PM Will Deacon <will@kernel.org> wrote:
> >
> > On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote:
> > > machine_kexec_post_load() is called after kexec load is finished. It must
> > > be declared in public header not in kexec_internal.h
> >
> > Could you provide a log of what goes wrong without this patch, please?
> >
> > > Reported-by: kernel test robot <lkp@intel.com>
> >
> > Do you have a link to the report, or did it not go to the list?
>
> Hi Will,
>
> https://lore.kernel.org/linux-arm-kernel/202102030727.gqTokACH-lkp@intel.com/
>
> It is also linked in the cover letter.
Ah, great. Please add that as a Link: tag in the patch, and in-line the
compiler warning.
Will
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface
2021-02-19 19:14 ` Will Deacon
@ 2021-02-19 19:53 ` Pavel Tatashin
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Tatashin @ 2021-02-19 19:53 UTC (permalink / raw)
To: Will Deacon
Cc: Linux ARM, James Morris, LKML, Tyler Hicks, James Morse,
Eric W. Biederman, kexec mailing list
On Fri, Feb 19, 2021 at 2:14 PM Will Deacon <will@kernel.org> wrote:
>
> On Fri, Feb 19, 2021 at 02:06:31PM -0500, Pavel Tatashin wrote:
> > On Fri, Feb 19, 2021 at 12:53 PM Will Deacon <will@kernel.org> wrote:
> > >
> > > On Mon, Feb 15, 2021 at 01:59:08PM -0500, Pavel Tatashin wrote:
> > > > machine_kexec_post_load() is called after kexec load is finished. It must
> > > > be declared in public header not in kexec_internal.h
> > >
> > > Could you provide a log of what goes wrong without this patch, please?
> > >
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > Do you have a link to the report, or did it not go to the list?
> >
> > Hi Will,
> >
> > https://lore.kernel.org/linux-arm-kernel/202102030727.gqTokACH-lkp@intel.com/
> >
> > It is also linked in the cover letter.
>
> Ah, great. Please add that as a Link: tag in the patch, and in-line the
> compiler warning.
Version 2 of this fix:
https://lore.kernel.org/lkml/20210219195142.13571-1-pasha.tatashin@soleen.com/
With the tag link, and warning in-lined.
Thank you,
Pasha
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-19 19:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 18:59 [PATCH 0/1] fix machine_kexec_post_load prototype Pavel Tatashin
2021-02-15 18:59 ` [PATCH 1/1] kexec: move machine_kexec_post_load() to public interface Pavel Tatashin
2021-02-19 17:53 ` Will Deacon
2021-02-19 19:06 ` Pavel Tatashin
2021-02-19 19:14 ` Will Deacon
2021-02-19 19:53 ` Pavel Tatashin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).