From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D87AC433DB for ; Fri, 19 Feb 2021 06:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D777564EC4 for ; Fri, 19 Feb 2021 06:28:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbhBSG2j (ORCPT ); Fri, 19 Feb 2021 01:28:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56565 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbhBSG2f (ORCPT ); Fri, 19 Feb 2021 01:28:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613716028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gCPs0LwfLBhsO+47Q+nJV6cHRznWTPxUnG+Icxobtog=; b=QI+XOSX1SUNDtJ3kDaLK3poHuFYfqWL9S6vLWoMboWtv66rH6jutX6kLhtcyGP28A1nwfX WaBnbWXKsOn6djN0EizxAidkHE34dyrFQfU31wk7l65+E94era3WrmjFj9S898okYtq4th 5iKSeeflSFrPeQt2i46bIHTvHqbSgs4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-cCyYogliOfy_i-FSH-lNHg-1; Fri, 19 Feb 2021 01:27:03 -0500 X-MC-Unique: cCyYogliOfy_i-FSH-lNHg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24542801965; Fri, 19 Feb 2021 06:27:02 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABEC45D9C2; Fri, 19 Feb 2021 06:26:53 +0000 (UTC) Date: Fri, 19 Feb 2021 01:26:51 -0500 From: Richard Guy Briggs To: Florian Westphal Cc: Phil Sutter , LKML , Linux-Audit Mailing List , netfilter-devel@vger.kernel.org, twoerner@redhat.com, Eric Paris , tgraf@infradead.org Subject: Re: [PATCH ghak124 v3] audit: log nftables configuration change events Message-ID: <20210219062651.GR2015948@madcap2.tricolour.ca> References: <20210211151606.GX3158@orbyte.nwl.cc> <20210211202628.GP2015948@madcap2.tricolour.ca> <20210211220930.GC2766@breakpoint.cc> <20210217234131.GN3141668@madcap2.tricolour.ca> <20210218082207.GJ2766@breakpoint.cc> <20210218124211.GO3141668@madcap2.tricolour.ca> <20210218125248.GB22944@breakpoint.cc> <20210218212001.GQ3141668@madcap2.tricolour.ca> <20210218224200.GF22944@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218224200.GF22944@breakpoint.cc> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-02-18 23:42, Florian Westphal wrote: > Richard Guy Briggs wrote: > > > If they appear in a batch tehy will be ignored, if the batch consists of > > > such non-modifying ops only then nf_tables_commit() returns early > > > because the transaction list is empty (nothing to do/change). > > > > Ok, one little inconvenient question: what about GETOBJ_RESET? That > > looks like a hybrid that modifies kernel table counters and reports > > synchronously. That could be a special case call in > > nf_tables_dump_obj() and nf_tables_getobj(). Will that cause a storm > > per commit? > > No, since they can't be part of a commit (they don't implement the > 'call_batch' function). Ok, good, so they should be safe (but still needs the gfp param to audit_log_nfcfg() for atomic alloc in that obj reset callback). > I'm not sure GETOBJ_RESET should be reported in the first place: > RESET only affects expr internal state, and that state changes all the time > anyway in response to network traffic. We report audit lost messages reset as a config change since it affects the view that an admin has about a system. An unaccounted for reset could mislead an administrator into thinking things are alright when some messages were lost and there was nothing to show for it. I could see similar situations with network entity counters. - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635