From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC16AC433E6 for ; Fri, 19 Feb 2021 07:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B9E564EC7 for ; Fri, 19 Feb 2021 07:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbhBSHCr (ORCPT ); Fri, 19 Feb 2021 02:02:47 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:35522 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhBSHCn (ORCPT ); Fri, 19 Feb 2021 02:02:43 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11J701uF003546; Fri, 19 Feb 2021 07:01:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=1ceI6DD+xmiJ0cdTdA9pJd22cFRKfq1rVJZSzsVyRBM=; b=yODk4U5fd2Dp0rMAh+wgA7J/TgiTGoNjFTli0nVuEc4B63rN9sreO+Jrr2lfO6plv+ck hSv7cnAYw5tslmpg51HbO7WSvlR1NhcxEMALWfkHhC9htNfdgUbgwOj7Krry6VrWx8/Z HGC8qdxH8kZxHF4TBbk1s3FXgyu8a8CeUhPzjOgLJp8QiVkbGvUv+4ROSgTfWYF5kt50 jTUjwmEDaZfHR+1GROG54O00eKwvkskKV8KcJVxEkuJ7OHSRrmE5h9O/hIP+eZGmROIf L0sh/zSQ/y3WUbYCCGFDDAfl4VZu7Qd92J8cCL2BgUTC2z53zhv0UrDsifB8uDJzhPVO 8Q== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 36pd9afyeh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Feb 2021 07:01:51 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11J70NKl061495; Fri, 19 Feb 2021 07:01:49 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 36prp2jk1p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Feb 2021 07:01:49 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 11J71mdE014345; Fri, 19 Feb 2021 07:01:48 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 18 Feb 2021 23:01:48 -0800 Date: Fri, 19 Feb 2021 10:01:40 +0300 From: Dan Carpenter To: Kurt Manucredo Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, d.straghkov@ispras.ru, tiwai@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform Message-ID: <20210219070139.GP2222@kadam> References: <20210218194830.8-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218194830.8-1-fuzzybritches@protonmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102190051 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9899 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 impostorscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102190051 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 07:50:27PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > The preferred coding style is: > if (!StaAddr) > return; Above the Signed-off-by line. Also indenting is wrong. And it's hard to understand what you're saying. > > thank you mr. dan carpenter You're welcome. (These sorts of comments do go below the --- cut off line so that's fine.) regards, dan carpenter