From: Pavel Machek <pavel@ucw.cz>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: Andreas Eberlein <foodeas@aeberlein.de>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware
Date: Fri, 19 Feb 2021 12:21:55 +0100 [thread overview]
Message-ID: <20210219112155.GL19207@duo.ucw.cz> (raw)
In-Reply-To: <c7eebbb6-df0c-51df-7701-ecb8f6543466@metux.net>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
> > MODULE_DEVICE_TABLE(dmi, apu_led_dmi_table);
> > @@ -173,7 +182,7 @@ static int __init apu_led_init(void)
> > int err;
> > if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") &&
> > - dmi_match(DMI_PRODUCT_NAME, "APU"))) {
> > + (dmi_match(DMI_PRODUCT_NAME, "APU") || dmi_match(DMI_PRODUCT_NAME, "apu1")))) {
> > pr_err("No PC Engines APUv1 board detected. For APUv2,3 support, enable CONFIG_PCENGINES_APU2\n");
> > return -ENODEV;
> > }
> >
>
> Looks good to me. But don't dare giving official ack, since I don't
> have an apu1 board for testing.
>
> Is Alan Mizrahi (original author) still here ?
People are usually not that careful with thier acks.
Applied, thanks.
BR,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-02-19 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 13:30 [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware Andreas Eberlein
2021-02-17 11:02 ` Enrico Weigelt, metux IT consult
2021-02-19 11:21 ` Pavel Machek [this message]
2021-02-19 14:37 ` Petr Štetiar
2021-02-19 20:51 ` Zbyněk Kocur
2021-02-23 20:02 ` Enrico Weigelt, metux IT consult
2021-02-23 21:13 ` Zbyněk Kocur
2021-02-19 20:59 ` Zbyněk Kocur
2021-03-06 16:51 ` Alexander Dahl
2021-03-18 19:51 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219112155.GL19207@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=foodeas@aeberlein.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkml@metux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).