* [PATCH v2] staging: rtl8723bs: fix code style comparison warning
@ 2021-02-19 14:50 Kurt Manucredo
2021-02-19 16:25 ` Greg KH
2021-02-19 17:14 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Kurt Manucredo @ 2021-02-19 14:50 UTC (permalink / raw)
To: gregkh, ross.schm.dev, straube.linux, dan.carpenter, d.straghkov, tiwai
Cc: Kurt Manucredo, devel, linux-kernel
changes since previous version:
- change Subject line
- change commit message
- change commit message position to above signed-off-by
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
struct security_priv *psecpriv = &padapter->securitypriv;
memset(pcur_dot11txpn, 0, 8);
- if (NULL == StaAddr)
+ if (!StaAddr)
return;
psta = rtw_get_stainfo(&padapter->stapriv, StaAddr);
DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning
2021-02-19 14:50 [PATCH v2] staging: rtl8723bs: fix code style comparison warning Kurt Manucredo
@ 2021-02-19 16:25 ` Greg KH
2021-02-19 17:14 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-02-19 16:25 UTC (permalink / raw)
To: Kurt Manucredo
Cc: ross.schm.dev, straube.linux, dan.carpenter, d.straghkov, tiwai,
devel, linux-kernel
On Fri, Feb 19, 2021 at 02:50:53PM +0000, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
This all goes below the --- line please.
Please make a v3.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning
2021-02-19 14:50 [PATCH v2] staging: rtl8723bs: fix code style comparison warning Kurt Manucredo
2021-02-19 16:25 ` Greg KH
@ 2021-02-19 17:14 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-02-19 17:14 UTC (permalink / raw)
To: Kurt Manucredo
Cc: gregkh, ross.schm.dev, straube.linux, d.straghkov, tiwai, devel,
linux-kernel
On Fri, Feb 19, 2021 at 02:50:53PM +0000, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
>
These comments need to go below the --- cut off line.
> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
^^^
This one here.
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-19 18:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 14:50 [PATCH v2] staging: rtl8723bs: fix code style comparison warning Kurt Manucredo
2021-02-19 16:25 ` Greg KH
2021-02-19 17:14 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).