From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C725AC433DB for ; Fri, 19 Feb 2021 18:25:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FCD064E76 for ; Fri, 19 Feb 2021 18:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbhBSSYr (ORCPT ); Fri, 19 Feb 2021 13:24:47 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:15204 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhBSSYo (ORCPT ); Fri, 19 Feb 2021 13:24:44 -0500 Date: Fri, 19 Feb 2021 18:23:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1613759038; bh=INaW8+67y2Qr+AIhL2pM7hrEvl532xeKD+BY3hq66KE=; h=Date:To:From:Cc:Reply-To:Subject:From; b=ZeIXOuhZLe2y1vN9M39L7Bs8Vnq3W5g3wQeoAHeKPcVy5k4zNwxfUav5KXrBBHBSN UPTAbLBTbY5ni3uOkGp1CDe3o2CnQPXTL/npHxLfhwtIt+bJ91j86J9Jmjh61C4ISF 32boGRavG0K//mFdcGin2L/kPcaOrQtL5S/O9X+g= To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, straube.linux@gmail.com, dan.carpenter@oracle.com, d.straghkov@ispras.ru, tiwai@suse.de From: Kurt Manucredo Cc: Kurt Manucredo , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Reply-To: Kurt Manucredo Subject: [PATCH v3] staging: rtl8723bs: fix code style comparison warning Message-ID: <20210219182331.8-1-fuzzybritches@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org checkpatch gives the following WARNING: WARNING: Comparisons should place the constant on the right side of the tes= t this patch fixes the coding style warning. Signed-off-by: Kurt Manucredo --- changes since previous version: - put version chatter below the --- cut off line. thank you very much for your help Mr. Dan Carpenter. drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 975f2830e29e..96feced698ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcu= r_dot11txpn, u8 *StaAddr) =09struct security_priv *psecpriv =3D &padapter->securitypriv; =20 =09memset(pcur_dot11txpn, 0, 8); -=09if (NULL =3D=3D StaAddr) +=09if (!StaAddr) =09=09return; =09psta =3D rtw_get_stainfo(&padapter->stapriv, StaAddr); =09DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", --=20 2.20.1