From: Pavel Machek <pavel@ucw.cz>
To: Johan Hovold <johan@kernel.org>
Cc: Greg KH <greg@kroah.com>,
kernel list <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org, tony@atomide.com
Subject: Re: [RFC/context] add serdev interfaces to n_gsm
Date: Fri, 19 Feb 2021 23:06:26 +0100 [thread overview]
Message-ID: <20210219220626.GB31435@amd> (raw)
In-Reply-To: <YCTzKm+70jwqkdLK@hovoldconsulting.com>
[-- Attachment #1: Type: text/plain, Size: 2377 bytes --]
Hi!
> > > > > +config GNSS_MOTMDM
> > > > > + tristate "Motorola Modem TS 27.010 serdev GNSS receiver support"
> > > > > + depends on SERIAL_DEV_N_GSM
> > > >
> > > > You need to post this driver together with the serdev-ngsm driver. This
> > > > one cannot currently even be built without it, but we also need to see
> > > > the greater picture here.
> > >
> > > Well, here it is, for greater picture. But it is not ready. Current
> > > problem I have is gsm_serdev_register_tty_port(). The way I do
> > > platform device registration causes oops on module unload. Help with
> > > that would be welcome
> >
> > I would not mind comments on parent patch and some help here.
> >
> > Basically I tried to work around limitation in
> >
> > int serdev_device_add(struct serdev_device *serdev)
> > {
> > ...
> > /* Only a single slave device is currently supported. */
> > if (ctrl->serdev) {
> > ...
>
> I haven't really had time to look at the code yet, but trying to work
> around the single-client (slave) assumption seems wrong. You still have
> only one client per port even if the mux driver provides multiple
> (virtual) ports.
Correct.
But this limitation prevents me to registering multiple slave ports
with master serdev as their parent.
a) There's a physical line
b) Then there's serdev connected to it
c) Mux splits it to many virtual ports, but I still need something to
specify as their parent. serdev b) would be most suitable, but this
check prevents that.
> But judging from a quick look it appears that you are indeed registering
> one tty device per mux channel in gsm_serdev_register_tty_port() (as you
> should) so perhaps that's not the issue here.
>
> Do you have a stack trace from the oops? Are the client drivers holding
> the ports open while you unload the parent driver? That sounds like
> something which could go boom unless you pin the parent for example
> (serdev doesn't support hangups).
>
> Also, did you forget to post the gsm_tty_driver implementation? I don't
> see a definition of that symbol in the patch.
I'll gather the data in next debugging session.
But .... this way I have to provide fake platform device parent for
gsmtty1 and friends, and that just feels wrong.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-02-19 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 22:45 [PATCH] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Pavel Machek
2021-01-28 18:34 ` Pavel Machek
[not found] ` <YBQvvUitX4MtRrh+@hovoldconsulting.com>
2021-01-29 22:34 ` Pavel Machek
[not found] ` <20210131170639.GA21067@duo.ucw.cz>
2021-02-10 21:28 ` [RFC/context] add serdev interfaces to n_gsm Pavel Machek
2021-02-11 9:04 ` Johan Hovold
2021-02-19 22:06 ` Pavel Machek [this message]
2021-01-29 22:42 ` [PATCHv2] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Pavel Machek
2021-02-28 20:46 ` Pavel Machek
2021-04-01 9:39 ` Johan Hovold
2021-04-07 10:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219220626.GB31435@amd \
--to=pavel@ucw.cz \
--cc=greg@kroah.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).