From: Matthew Wilcox <willy@infradead.org>
To: David Laight <David.Laight@aculab.com>
Cc: 'SelvaKumar S' <selvakuma.s1@samsung.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"selvajove@gmail.com" <selvajove@gmail.com>,
"joshiiitr@gmail.com" <joshiiitr@gmail.com>,
"nj.shetty@samsung.com" <nj.shetty@samsung.com>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"javier.gonz@samsung.com" <javier.gonz@samsung.com>,
"kch@kernel.org" <kch@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH v5 0/4] add simple copy support
Date: Sat, 20 Feb 2021 19:08:37 +0000 [thread overview]
Message-ID: <20210220190837.GE2858050@casper.infradead.org> (raw)
In-Reply-To: <146c47907c2446d4a896830de400dd81@AcuMS.aculab.com>
On Sat, Feb 20, 2021 at 06:01:56PM +0000, David Laight wrote:
> From: SelvaKumar S
> > Sent: 19 February 2021 12:45
> >
> > This patchset tries to add support for TP4065a ("Simple Copy Command"),
> > v2020.05.04 ("Ratified")
> >
> > The Specification can be found in following link.
> > https://nvmexpress.org/wp-content/uploads/NVM-Express-1.4-Ratified-TPs-1.zip
> >
> > Simple copy command is a copy offloading operation and is used to copy
> > multiple contiguous ranges (source_ranges) of LBA's to a single destination
> > LBA within the device reducing traffic between host and device.
>
> Sounds to me like the real reason is that the copy just ends up changing
> some indirect block pointers rather than having to actually copy the data.
That would be incorrect, at least for firmware that I have knowledge of.
There are checksums which involve the logical block address of the data,
and you can't just rewrite the checksum on NAND, you have to write the
entire block.
Now, firmware doesn't have to implement their checksum like this,
but there are good reasons to do it this way (eg if the command gets
corrupted in transfer and you read the wrong block, it will fail the
checksum, preventing the drive from returning Somebody Else's Data).
So let's take these people at their word. It is to reduce traffic
between drive and host. And that is a good enough reason to do it.
next prev parent reply other threads:[~2021-02-20 19:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210219124555epcas5p1334e7c4d64ada5dc4a2ca0feb48c1d44@epcas5p1.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 0/4] add simple copy support SelvaKumar S
[not found] ` <CGME20210219124559epcas5p41da46f1c248e334953d407a154697903@epcas5p4.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 1/4] block: make bio_map_kern() non static SelvaKumar S
[not found] ` <CGME20210219124603epcas5p33add0f2c1781b2a4d71bf30c9e1ac647@epcas5p3.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 2/4] block: add simple copy support SelvaKumar S
2021-02-20 4:59 ` Damien Le Moal
2021-04-07 11:32 ` Selva Jove
2021-04-12 0:24 ` Damien Le Moal
2021-04-12 14:34 ` Selva Jove
2021-04-13 0:32 ` Damien Le Moal
2021-04-14 6:58 ` Selva Jove
[not found] ` <CGME20210219124608epcas5p2a673f9e00c3e7b5352f115497b0e2d98@epcas5p2.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 3/4] nvme: " SelvaKumar S
2021-02-20 3:36 ` Matthew Wilcox
2021-02-22 15:57 ` Selva Jove
[not found] ` <CGME20210219124611epcas5p1c775b63b537e75da161556e375fcf05e@epcas5p1.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 4/4] dm kcopyd: add simple copy offload support SelvaKumar S
2021-02-20 18:01 ` [RFC PATCH v5 0/4] add simple copy support David Laight
2021-02-20 19:08 ` Matthew Wilcox [this message]
2021-02-20 19:19 ` Keith Busch
2021-02-21 23:52 ` Dave Chinner
2021-02-23 9:14 ` Selva Jove
2021-02-22 1:31 ` Ming Lei
2021-02-22 6:52 ` Su Yue
2021-02-23 9:00 ` Selva Jove
2021-04-10 0:21 ` Max Gurtovoy
2021-04-10 0:29 ` Chaitanya Kulkarni
2021-04-10 6:32 ` Javier González
2021-04-11 9:10 ` Max Gurtovoy
2021-04-11 19:26 ` Javier González
2021-04-13 15:38 ` Max Gurtovoy
2021-04-13 18:25 ` Javier González
2021-04-13 18:36 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210220190837.GE2858050@casper.infradead.org \
--to=willy@infradead.org \
--cc=David.Laight@aculab.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=kch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=selvajove@gmail.com \
--cc=selvakuma.s1@samsung.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).