From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09281C433DB for ; Mon, 22 Feb 2021 07:54:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7B1064E07 for ; Mon, 22 Feb 2021 07:54:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230351AbhBVHxz (ORCPT ); Mon, 22 Feb 2021 02:53:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230258AbhBVHxq (ORCPT ); Mon, 22 Feb 2021 02:53:46 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 890BBC061574; Sun, 21 Feb 2021 23:53:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hqGoMx9Yapzi0ILQOi0zy5A/uV/LCC4QPknj+HY+INU=; b=EmdXJYOJXjM7STZpMm+JRsjv5p g8jamnJj8HF2tF46KSFOBqpCx9zSAUudtn1lPJ5/WVMg1i2agaoR7xfeF2L4sP57cQM7xqW1W/I3O Q/qpnEH68D9sPpB9ezdlL44Y+46Ov1/bEqQYMiIAi9Q1eNlvA+VaTRNjMfwsRn9rG7aOAhofTUpau j+IZOaEjmRnEn/shL3dVqffZFfVH5mA4yy2KWqfv1Pk17mB9VsLvNVIMAgY/WWD3WqHuOqm12mzbH S37wG/jHIZtOJlrIyUD4gE+G4cYhp6TFagVgz38xDBoM/x0Kp1c0NnxkNtImBFpRypqMobgl+g91X UBioS/JQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lE61C-006HOz-NC; Mon, 22 Feb 2021 07:52:36 +0000 Date: Mon, 22 Feb 2021 07:52:34 +0000 From: Christoph Hellwig To: Joao Martins Cc: Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Andrew Morton , Jason Gunthorpe , Doug Ledford , John Hubbard , Matthew Wilcox Subject: Re: [PATCH v4 0/4] mm/gup: page unpining improvements Message-ID: <20210222075234.GA1492783@infradead.org> References: <20210212130843.13865-1-joao.m.martins@oracle.com> <20210218072432.GA325423@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 03:33:39PM +0000, Joao Martins wrote: > in a bvec at once? e.g. something like from this: > > bio_for_each_segment_all(bvec, bio, iter_all) { > if (mark_dirty && !PageCompound(bvec->bv_page)) > set_page_dirty_lock(bvec->bv_page); > put_page(bvec->bv_page); > } > > (...) to this instead: > > bio_for_each_bvec_all(bvec, bio, i) > unpin_user_page_range_dirty_lock(bvec->bv_page, > DIV_ROUND_UP(bvec->bv_len, PAGE_SIZE), > mark_dirty && !PageCompound(bvec->bv_page)); Yes, like that modulo the fix in your reply and any other fixes.