From: Steven Rostedt <rostedt@goodmis.org>
To: Andrew Scull <ascull@google.com>
Cc: kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com,
julien.thierry.kdev@gmail.com, will@kernel.org,
catalin.marinas@arm.com, kernel-team@android.com,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 2/4] bug: Factor out a getter for a bug's file line
Date: Tue, 23 Feb 2021 11:35:30 -0500 [thread overview]
Message-ID: <20210223113530.3703dd19@gandalf.local.home> (raw)
In-Reply-To: <20210223155759.3495252-3-ascull@google.com>
On Tue, 23 Feb 2021 15:57:57 +0000
Andrew Scull <ascull@google.com> wrote:
> There is some non-trivial config-based logic to get the file name and
> line number associated with a bug. Factor this out to a getter that can
> be resused.
>
> Signed-off-by: Andrew Scull <ascull@google.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> ---
> include/linux/bug.h | 3 +++
> lib/bug.c | 27 +++++++++++++++++----------
> 2 files changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/bug.h b/include/linux/bug.h
> index f639bd0122f3..e3841bee4c8d 100644
> --- a/include/linux/bug.h
> +++ b/include/linux/bug.h
> @@ -36,6 +36,9 @@ static inline int is_warning_bug(const struct bug_entry *bug)
> return bug->flags & BUGFLAG_WARNING;
> }
>
> +void bug_get_file_line(struct bug_entry *bug, const char **file,
> + unsigned int *line);
> +
> struct bug_entry *find_bug(unsigned long bugaddr);
>
> enum bug_trap_type report_bug(unsigned long bug_addr, struct pt_regs *regs);
> diff --git a/lib/bug.c b/lib/bug.c
> index 4ab398a2de93..f936615176b8 100644
> --- a/lib/bug.c
> +++ b/lib/bug.c
> @@ -130,6 +130,22 @@ static inline struct bug_entry *module_find_bug(unsigned long bugaddr)
> }
> #endif
>
> +void bug_get_file_line(struct bug_entry *bug, const char **file,
> + unsigned int *line)
> +{
> + *file = NULL;
> + *line = 0;
> +
> +#ifdef CONFIG_DEBUG_BUGVERBOSE
> +#ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
> + *file = bug->file;
> +#else
> + *file = (const char *)bug + bug->file_disp;
> +#endif
> + *line = bug->line;
Not that it should be part of this patch, as this patch is moving the code
and shouldn't modify it, but as a micro optimization, we could remove the
initialization from the beginning and place it here:
#else
*file = NULL;
*line = 0;
But again, this patch is fine.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> +#endif
> +}
> +
> struct bug_entry *find_bug(unsigned long bugaddr)
> {
> struct bug_entry *bug;
> @@ -156,17 +172,8 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
>
> disable_trace_on_warning();
>
> - file = NULL;
> - line = 0;
> + bug_get_file_line(bug, &file, &line);
>
> -#ifdef CONFIG_DEBUG_BUGVERBOSE
> -#ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
> - file = bug->file;
> -#else
> - file = (const char *)bug + bug->file_disp;
> -#endif
> - line = bug->line;
> -#endif
> warning = (bug->flags & BUGFLAG_WARNING) != 0;
> once = (bug->flags & BUGFLAG_ONCE) != 0;
> done = (bug->flags & BUGFLAG_DONE) != 0;
next prev parent reply other threads:[~2021-02-23 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 15:57 [PATCH v2 0/4] Debug info for nVHE hyp panics Andrew Scull
2021-02-23 15:57 ` [PATCH v2 1/4] bug: Remove redundant condition check in report_bug Andrew Scull
2021-02-23 16:25 ` Steven Rostedt
2021-02-23 15:57 ` [PATCH v2 2/4] bug: Factor out a getter for a bug's file line Andrew Scull
2021-02-23 16:35 ` Steven Rostedt [this message]
2021-02-23 15:57 ` [PATCH v2 3/4] KVM: arm64: Use BUG and BUG_ON in nVHE hyp Andrew Scull
2021-02-23 15:57 ` [PATCH v2 4/4] KVM: arm64: Log source when panicking from " Andrew Scull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223113530.3703dd19@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ascull@google.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).