From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: dingsenjie@163.com
Cc: gregkh@linuxfoundation.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, dingsenjie <dingsenjie@yulong.com>
Subject: Re: [PATCH] tty/serial:Remove superfluous "breaks"
Date: Tue, 23 Feb 2021 15:23:48 +0100 [thread overview]
Message-ID: <20210223142348.7wsgp4qdpkmkcmmz@pengutronix.de> (raw)
In-Reply-To: <20210223080630.44644-1-dingsenjie@163.com>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On Tue, Feb 23, 2021 at 04:06:30PM +0800, dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
>
> Remove superfluous "breaks", as there is a "return" before them.
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
You are at least the fourth person who sends this patch[1]. The things I
wrote in reply to the latest submission still applies:
- the Subject is wrong, it should use a prefix similar to "serial: imx:".
- I personally like the breaks for clarity.
- If people agree enough to outvote me, please at least add an empty
line instead of just removing the break to visually separate the
cases.
Thanks
Uwe
[1] https://lore.kernel.org/r/20201026125142.21105-1-zhangqilong3@huawei.com
https://lore.kernel.org/r/20201020130709.28096-1-trix@redhat.com
https://lore.kernel.org/r/20201107140129.kpfhanzjidvdg662@pengutronix.de
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-02-23 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 8:06 [PATCH] tty/serial:Remove superfluous "breaks" dingsenjie
2021-02-23 11:23 ` Greg KH
2021-02-23 14:23 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223142348.7wsgp4qdpkmkcmmz@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dingsenjie@163.com \
--cc=dingsenjie@yulong.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).