Re: [PATCH v2] memcg: charge before adding to swapcache on swapin

From: kernel test robot <lkp@intel.com>
To: Shakeel Butt <shakeelb@google.com>,
	Hugh Dickins <hughd@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: kbuild-all@lists.01.org, Roman Gushchin <guro@fb.com>,
	Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shakeel Butt <shakeelb@google.com>
Subject: Re: [PATCH v2] memcg: charge before adding to swapcache on swapin
Date: Tue, 23 Feb 2021 15:12:05 +0800	[thread overview]
Message-ID: <202102231552.njMnzSrZ-lkp@intel.com> (raw)
In-Reply-To: <20210223055505.2594953-1-shakeelb@google.com>

[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]

Hi Shakeel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20210222]
[cannot apply to linus/master hnaz-linux-mm/master v5.11 v5.11-rc7 v5.11-rc6 v5.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shakeel-Butt/memcg-charge-before-adding-to-swapcache-on-swapin/20210223-135711
base:    37dfbfbdca66834bc0f64ec9b35e09ac6c8898da
config: arm-colibri_pxa300_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/7ad6fb47580886394809b563b7476954a35f3054
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shakeel-Butt/memcg-charge-before-adding-to-swapcache-on-swapin/20210223-135711
        git checkout 7ad6fb47580886394809b563b7476954a35f3054
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/swap.h:9,
                    from mm/swap_state.c:13:
   include/linux/memcontrol.h:1149:1: error: expected identifier or '(' before '{' token
    1149 | {
         | ^
>> include/linux/memcontrol.h:1147:19: warning: 'mem_cgroup_charge_swapin_page' used but never defined
    1147 | static inline int mem_cgroup_charge_swapin_page(struct page *page,
         |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/mem_cgroup_charge_swapin_page +1147 include/linux/memcontrol.h

  1146	
> 1147	static inline int mem_cgroup_charge_swapin_page(struct page *page,
  1148				struct mm_struct *mm, gfp_t gfp, swp_entry_t entry);
> 1149	{
  1150		return 0;
  1151	}
  1152	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 14471 bytes --]