From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11289C433E0 for ; Tue, 23 Feb 2021 16:56:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D347860295 for ; Tue, 23 Feb 2021 16:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233653AbhBWQ4T (ORCPT ); Tue, 23 Feb 2021 11:56:19 -0500 Received: from netrider.rowland.org ([192.131.102.5]:60701 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S233635AbhBWQ4E (ORCPT ); Tue, 23 Feb 2021 11:56:04 -0500 Received: (qmail 1267268 invoked by uid 1000); 23 Feb 2021 11:55:21 -0500 Date: Tue, 23 Feb 2021 11:55:21 -0500 From: Alan Stern To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: f.fainelli@gmail.com, jonas.gorski@gmail.com, Greg Kroah-Hartman , Rob Herring , Tony Prisk , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] usb: host: ehci-platform: add ignore_oc DT support Message-ID: <20210223165521.GE1261797@rowland.harvard.edu> References: <20210223155005.21712-1-noltari@gmail.com> <20210223161644.6095-1-noltari@gmail.com> <20210223161644.6095-3-noltari@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210223161644.6095-3-noltari@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2021 at 05:16:44PM +0100, Álvaro Fernández Rojas wrote: > Over-current reporting isn't supported on some platforms such as bcm63xx. > These devices will incorrectly report over-current if this flag isn't properly > activated. > > Signed-off-by: Álvaro Fernández Rojas > --- > v2: change flag name and improve documentation as suggested by Alan Stern. > > drivers/usb/host/ehci-platform.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c > index a48dd3fac153..2c587e31d010 100644 > --- a/drivers/usb/host/ehci-platform.c > +++ b/drivers/usb/host/ehci-platform.c > @@ -286,6 +286,9 @@ static int ehci_platform_probe(struct platform_device *dev) > if (of_property_read_bool(dev->dev.of_node, "big-endian")) > ehci->big_endian_mmio = ehci->big_endian_desc = 1; > > + if (of_property_read_bool(dev->dev.of_node, "spurious-oc")) > + ehci->ignore_oc = 1; > + > if (of_property_read_bool(dev->dev.of_node, > "needs-reset-on-resume")) > priv->reset_on_resume = true; Acked-by: Alan Stern