* [PATCH 1/1] KVM: x86: remove incorrect comment on active_mmu_pages
@ 2021-02-23 20:37 Dongli Zhang
2021-02-26 0:44 ` Sean Christopherson
0 siblings, 1 reply; 3+ messages in thread
From: Dongli Zhang @ 2021-02-23 20:37 UTC (permalink / raw)
To: x86, kvm
Cc: linux-kernel, pbonzini, seanjc, vkuznets, wanpengli, jmattson,
joro, tglx, mingo, bp, hpa
The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a
list. This patch removes the incorrect comment on active_mmu_pages.
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
arch/x86/include/asm/kvm_host.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 84499aad01a4..318242512407 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -937,9 +937,6 @@ struct kvm_arch {
unsigned int indirect_shadow_pages;
u8 mmu_valid_gen;
struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
- /*
- * Hash table of struct kvm_mmu_page.
- */
struct list_head active_mmu_pages;
struct list_head zapped_obsolete_pages;
struct list_head lpage_disallowed_mmu_pages;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] KVM: x86: remove incorrect comment on active_mmu_pages
2021-02-23 20:37 [PATCH 1/1] KVM: x86: remove incorrect comment on active_mmu_pages Dongli Zhang
@ 2021-02-26 0:44 ` Sean Christopherson
2021-02-26 5:39 ` Dongli Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Sean Christopherson @ 2021-02-26 0:44 UTC (permalink / raw)
To: Dongli Zhang
Cc: x86, kvm, linux-kernel, pbonzini, vkuznets, wanpengli, jmattson,
joro, tglx, mingo, bp, hpa
On Tue, Feb 23, 2021, Dongli Zhang wrote:
> The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a
> list. This patch removes the incorrect comment on active_mmu_pages.
Maybe change the last sentence to "Remove the misplaced comment, it's mostly
stating the obvious anyways." It's more misplaced than flat out incorrect, e.g.
the alternative would be to hoist the comment above mmu_page_hash. I like
removing it though, IMO mmu_page_hash is the most obvious name out of the
various structures that track shadow pages.
With that tweak:
Reviewed-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
> arch/x86/include/asm/kvm_host.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 84499aad01a4..318242512407 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -937,9 +937,6 @@ struct kvm_arch {
> unsigned int indirect_shadow_pages;
> u8 mmu_valid_gen;
> struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
> - /*
> - * Hash table of struct kvm_mmu_page.
> - */
> struct list_head active_mmu_pages;
> struct list_head zapped_obsolete_pages;
> struct list_head lpage_disallowed_mmu_pages;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] KVM: x86: remove incorrect comment on active_mmu_pages
2021-02-26 0:44 ` Sean Christopherson
@ 2021-02-26 5:39 ` Dongli Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Dongli Zhang @ 2021-02-26 5:39 UTC (permalink / raw)
To: Sean Christopherson
Cc: x86, kvm, linux-kernel, pbonzini, vkuznets, wanpengli, jmattson,
joro, tglx, mingo, bp, hpa
On 2/25/21 4:44 PM, Sean Christopherson wrote:
> On Tue, Feb 23, 2021, Dongli Zhang wrote:
>> The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a
>> list. This patch removes the incorrect comment on active_mmu_pages.
>
> Maybe change the last sentence to "Remove the misplaced comment, it's mostly
> stating the obvious anyways." It's more misplaced than flat out incorrect, e.g.
> the alternative would be to hoist the comment above mmu_page_hash. I like
> removing it though, IMO mmu_page_hash is the most obvious name out of the
> various structures that track shadow pages.
Thank you very much!
I will change the last sentence and send v2 with your Reviewed-by.
Dongli Zhang
>
> With that tweak:
>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
>
>
>> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
>> ---
>> arch/x86/include/asm/kvm_host.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
>> index 84499aad01a4..318242512407 100644
>> --- a/arch/x86/include/asm/kvm_host.h
>> +++ b/arch/x86/include/asm/kvm_host.h
>> @@ -937,9 +937,6 @@ struct kvm_arch {
>> unsigned int indirect_shadow_pages;
>> u8 mmu_valid_gen;
>> struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
>> - /*
>> - * Hash table of struct kvm_mmu_page.
>> - */
>> struct list_head active_mmu_pages;
>> struct list_head zapped_obsolete_pages;
>> struct list_head lpage_disallowed_mmu_pages;
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-26 5:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 20:37 [PATCH 1/1] KVM: x86: remove incorrect comment on active_mmu_pages Dongli Zhang
2021-02-26 0:44 ` Sean Christopherson
2021-02-26 5:39 ` Dongli Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).