Re: [PATCH 2/2] usb: host: ehci-platform: add ignore-oc DT support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5580 bytes --]

Hi "Álvaro,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.11 next-20210223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/usb-host-ehci-platform-add-ignore-oc-DT-support/20210223-235717
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: mips-randconfig-r022-20210223 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/cb5cc55cab35476258f04e40cac0a9dd02271475
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review lvaro-Fern-ndez-Rojas/usb-host-ehci-platform-add-ignore-oc-DT-support/20210223-235717
        git checkout cb5cc55cab35476258f04e40cac0a9dd02271475
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/usb/host/ehci-platform.c:290:10: error: no member named 'ignore_oc' in 'struct ehci_hcd'
                           ehci->ignore_oc = 1;
                           ~~~~  ^
>> drivers/usb/host/ehci-platform.c:259:24: warning: shift count >= width of type [-Wshift-count-overflow]
                   pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
                                        ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
   #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
                                                        ^ ~~~
   1 warning and 1 error generated.


vim +290 drivers/usb/host/ehci-platform.c

   238	
   239	static int ehci_platform_probe(struct platform_device *dev)
   240	{
   241		struct usb_hcd *hcd;
   242		struct resource *res_mem;
   243		struct usb_ehci_pdata *pdata = dev_get_platdata(&dev->dev);
   244		struct ehci_platform_priv *priv;
   245		struct ehci_hcd *ehci;
   246		int err, irq, clk = 0;
   247	
   248		if (usb_disabled())
   249			return -ENODEV;
   250	
   251		/*
   252		 * Use reasonable defaults so platforms don't have to provide these
   253		 * with DT probing on ARM.
   254		 */
   255		if (!pdata)
   256			pdata = &ehci_platform_defaults;
   257	
   258		err = dma_coerce_mask_and_coherent(&dev->dev,
 > 259			pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
   260		if (err) {
   261			dev_err(&dev->dev, "Error: DMA mask configuration failed\n");
   262			return err;
   263		}
   264	
   265		irq = platform_get_irq(dev, 0);
   266		if (irq < 0)
   267			return irq;
   268	
   269		hcd = usb_create_hcd(&ehci_platform_hc_driver, &dev->dev,
   270				     dev_name(&dev->dev));
   271		if (!hcd)
   272			return -ENOMEM;
   273	
   274		platform_set_drvdata(dev, hcd);
   275		dev->dev.platform_data = pdata;
   276		priv = hcd_to_ehci_priv(hcd);
   277		ehci = hcd_to_ehci(hcd);
   278	
   279		if (pdata == &ehci_platform_defaults && dev->dev.of_node) {
   280			if (of_property_read_bool(dev->dev.of_node, "big-endian-regs"))
   281				ehci->big_endian_mmio = 1;
   282	
   283			if (of_property_read_bool(dev->dev.of_node, "big-endian-desc"))
   284				ehci->big_endian_desc = 1;
   285	
   286			if (of_property_read_bool(dev->dev.of_node, "big-endian"))
   287				ehci->big_endian_mmio = ehci->big_endian_desc = 1;
   288	
   289			if (of_property_read_bool(dev->dev.of_node, "ignore-oc"))
 > 290				ehci->ignore_oc = 1;
   291	
   292			if (of_property_read_bool(dev->dev.of_node,
   293						  "needs-reset-on-resume"))
   294				priv->reset_on_resume = true;
   295	
   296			if (of_property_read_bool(dev->dev.of_node,
   297						  "has-transaction-translator"))
   298				hcd->has_tt = 1;
   299	
   300			if (soc_device_match(quirk_poll_match))
   301				priv->quirk_poll = true;
   302	
   303			for (clk = 0; clk < EHCI_MAX_CLKS; clk++) {
   304				priv->clks[clk] = of_clk_get(dev->dev.of_node, clk);
   305				if (IS_ERR(priv->clks[clk])) {
   306					err = PTR_ERR(priv->clks[clk]);
   307					if (err == -EPROBE_DEFER)
   308						goto err_put_clks;
   309					priv->clks[clk] = NULL;
   310					break;
   311				}
   312			}
   313		}
   314	
   315		priv->rsts = devm_reset_control_array_get_optional_shared(&dev->dev);
   316		if (IS_ERR(priv->rsts)) {
   317			err = PTR_ERR(priv->rsts);
   318			goto err_put_clks;
   319		}
   320	
   321		err = reset_control_deassert(priv->rsts);
   322		if (err)
   323			goto err_put_clks;
   324	
   325		if (pdata->big_endian_desc)
   326			ehci->big_endian_desc = 1;
   327		if (pdata->big_endian_mmio)
   328			ehci->big_endian_mmio = 1;
   329		if (pdata->has_tt)
   330			hcd->has_tt = 1;
   331		if (pdata->reset_on_resume)
   332			priv->reset_on_resume = true;
   333	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40006 bytes --]