From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 882CBC433DB for ; Fri, 26 Feb 2021 12:11:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2732B64E38 for ; Fri, 26 Feb 2021 12:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbhBZMK6 (ORCPT ); Fri, 26 Feb 2021 07:10:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:60272 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbhBZMKy (ORCPT ); Fri, 26 Feb 2021 07:10:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8E171AB8C; Fri, 26 Feb 2021 12:10:13 +0000 (UTC) Date: Fri, 26 Feb 2021 13:10:11 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Michal Hocko , VlastimilBabkavbabka@suse.cz, pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH v2 7/7] arm64/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE Message-ID: <20210226121011.GD3661@localhost.localdomain> References: <20210209133854.17399-1-osalvador@suse.de> <20210209133854.17399-8-osalvador@suse.de> <126fa740-c163-1463-ff48-dbec4ad17ed7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <126fa740-c163-1463-ff48-dbec4ad17ed7@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2021 at 07:29:23PM +0100, David Hildenbrand wrote: > On 09.02.21 14:38, Oscar Salvador wrote: > > Enable arm64 platform to use the MHP_MEMMAP_ON_MEMORY feature. > > > > Signed-off-by: Oscar Salvador > > --- > > arch/arm64/Kconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 87fd02a7a62f..d4fb29779cd4 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -309,6 +309,10 @@ config ARCH_ENABLE_MEMORY_HOTPLUG > > config ARCH_ENABLE_MEMORY_HOTREMOVE > > def_bool y > > +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > > + def_bool y > > + depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP_ENABLE > > + > > Same comment as for x86-64 variant. >From arm64/Kconfig: config ARCH_SPARSEMEM_ENABLE def_bool y select SPARSEMEM_VMEMMAP_ENABLE config ARCH_SPARSEMEM_DEFAULT def_bool ARCH_SPARSEMEM_ENABLE config ARCH_SELECT_MEMORY_MODEL def_bool ARCH_SPARSEMEM_ENABLE config ARCH_FLATMEM_ENABLE def_bool !NUMA It seems SPARSEMEM_VMEMMAP_ENABLE is ticked by default unless we are on a !NUMA system. So make it dependent on SPARSEMEM_VMEMMAP_ENABLE seems the right thing to do? -- Oscar Salvador SUSE L3