From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B02C43381 for ; Mon, 1 Mar 2021 00:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A30864E68 for ; Mon, 1 Mar 2021 00:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbhCAAHs (ORCPT ); Sun, 28 Feb 2021 19:07:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:41932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230412AbhCAAHp (ORCPT ); Sun, 28 Feb 2021 19:07:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93C2B64E10; Mon, 1 Mar 2021 00:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614557224; bh=EOHLpSwtZLgHIs2j7IOL7U85lAC+hVAOyqWikacMpr0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=iEvPjBP4gy8IEo+NgPOGnBYkzpA1rt5YpMo9j425qNB8oJr3YsHxy5MOFtIMgFkSU FKtGJeg0R2EsTHdHKw6fp8sxo7Kdtm5ESi97M0On04Kd8VD3CNfNOIXdQE7/1QLSy7 SGBrMvcjB2ht7vyj+/4FDDz+JE42xXYE/QdZnLBLkj9PaLaFK16dP/sLbM4NUeGbGV qKn9TgVtHOxrk2322+mHRigjqazbPyXC8Bd+0JuJ1jmGlx87U/pE1SVGGb6DYSI8Im xh0EkMXUf/iamgIh2BaBMgdhJa8ldUMF1bNOr693Mbpu6+ftd5+qqfzkus6yHvQuuY B5J3z6rFPWApQ== Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 5547335239D3; Sun, 28 Feb 2021 16:07:04 -0800 (PST) Date: Sun, 28 Feb 2021 16:07:04 -0800 From: "Paul E. McKenney" To: Peter Zijlstra Cc: Juergen Gross , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, mhocko@suse.com, Jonathan Corbet Subject: Re: [PATCH 3/3] kernel/smp: add more data to CSD lock debugging Message-ID: <20210301000704.GF2696@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20210226112521.8641-1-jgross@suse.com> <20210226112521.8641-4-jgross@suse.com> <20210226181205.GZ2743@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 10:05:51PM +0100, Peter Zijlstra wrote: > On Fri, Feb 26, 2021 at 10:12:05AM -0800, Paul E. McKenney wrote: > > On Fri, Feb 26, 2021 at 05:38:44PM +0100, Peter Zijlstra wrote: > > > > > > I hate all of this, but if this will finally catch the actual problem, > > > we can then revert all this, so sure. > > > > OK, I will bite... What exactly do you hate about it? > > It's ugly and messy. We're basically commiting a debug session. Normally > gunk like this is done in private trees, then we find the problem and > fix that and crap like this never sees the light of day. Is your hatred due to the presence of debug code at all, or a belief that this code is unlikely to be useful in any subsequent IPI-related bug hunt? Thanx, Paul