From: Pavel Machek <pavel@ucw.cz>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
linux-leds@vger.kernel.org,
Amireddy Mallikarjuna reddy
<mallikarjunax.reddy@linux.intel.com>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
Date: Tue, 2 Mar 2021 09:11:24 +0100 [thread overview]
Message-ID: <20210302081124.GA10699@amd> (raw)
In-Reply-To: <c4071c07-e882-96ca-a8fb-34ad1525305f@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
Hi!
> >>>> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
> >> gpiod_set_value(led->gpiod, val);
> >> ^
> >> drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean
> >> 'gpio_set_value'?
> >
> >
> > It looks like missing #include?
> >
> > While at it, can you do something with Kconfig help text? Move
> > existing one into comment in the driver, add something useful for end-users.
>
> The .config file does not set/enable GPIOLIB nor OF.
>
> AFAICT, this driver needs the addition of:
>
> #include <linux/gpio/consumer.h>
> #include <linux/gpio/driver.h>
> #include <linux/of.h>
>
> and the reference to
> gc->of_node = dev->of_node;
> needs to be inside an
> #ifdef CONFIG_GPIO/#endif block.
>
> Also, <linux/gpio/driver.h> needs a stub for gpiochip_get_data().
>
> I have most of that ready (it's in the margin) but I can't
> send it tonight. Feel free to fix it up however you want to.
Looking forward. I may be confused, but it looks like original
author's email bounces, which is a bad sign.
What I meant... if you take a look at Kconfig help test, it is really
useless.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2021-03-02 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 19:17 drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' kernel test robot
2021-02-28 8:29 ` Pavel Machek
2021-03-02 7:57 ` Randy Dunlap
2021-03-02 8:11 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302081124.GA10699@amd \
--to=pavel@ucw.cz \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).