From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE45C433E0 for ; Tue, 2 Mar 2021 13:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C087564EE4 for ; Tue, 2 Mar 2021 13:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1447880AbhCBNyA (ORCPT ); Tue, 2 Mar 2021 08:54:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:48568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350694AbhCBMXh (ORCPT ); Tue, 2 Mar 2021 07:23:37 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F176164FB5; Tue, 2 Mar 2021 11:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614686347; bh=eBXZVe8oAP8JEHXN/7PEqCSK7wv3FHWkSyCY4Em3XWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mqmi3s2cdixQ200X8WJ/CS7g99xgPQpdH04J+VCDZGxbPnT/yv8+5jh5WrMfAgZlc OqtySRyJFmz0heYVayt3eKynB5aBmdH52hwp4/jT7VuXosV/hoML2WVCm1X6UozmBj R4iUJQlDKJbva6mnUeH0Al38q1eA6I5kZ4Db1Zz82t4QujyW0Pv4E8DQplOpWbbM/p +idbOASUpSYhm9q1IdC4BGloIHYXkxZpb/LKtaM0EC7va4Lc3hVrQ3xZQ7gARcIm7/ PtCtnrWGsDZJAc5afjhVOXgPa9qrwKQ7ImnQuPbSPs1zw4v82Iaj43YVOOS9lIlEJw LJk9hFFuYKF8w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christophe JAILLET , Ulf Hansson , Sasha Levin , linux-mmc@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 02/13] mmc: mxs-mmc: Fix a resource leak in an error handling path in 'mxs_mmc_probe()' Date: Tue, 2 Mar 2021 06:58:52 -0500 Message-Id: <20210302115903.63458-2-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210302115903.63458-1-sashal@kernel.org> References: <20210302115903.63458-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 0bb7e560f821c7770973a94e346654c4bdccd42c ] If 'mmc_of_parse()' fails, we must undo the previous 'dma_request_chan()' call. Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/20201208203527.49262-1-christophe.jaillet@wanadoo.fr Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/mxs-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index add1e70195ea..7125687faf76 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -659,7 +659,7 @@ static int mxs_mmc_probe(struct platform_device *pdev) ret = mmc_of_parse(mmc); if (ret) - goto out_clk_disable; + goto out_free_dma; mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34; -- 2.30.1