From: Steven Rostedt <rostedt@goodmis.org>
To: Arseny Krasnov <arseny.krasnov@kaspersky.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Jorgen Hansen <jhansen@vmware.com>,
Norbert Slusarek <nslusarek@gmx.net>,
Andra Paraschiv <andraprs@amazon.com>,
Colin Ian King <colin.king@canonical.com>, <kvm@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stsp2@yandex.ru>, <oxffffaa@gmail.com>
Subject: Re: [RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET
Date: Tue, 2 Mar 2021 17:25:42 -0500 [thread overview]
Message-ID: <20210302172542.605b3795@gandalf.local.home> (raw)
In-Reply-To: <20210218054219.1069224-1-arseny.krasnov@kaspersky.com>
On Thu, 18 Feb 2021 08:42:15 +0300
Arseny Krasnov <arseny.krasnov@kaspersky.com> wrote:
Not sure if this was pulled in yet, but I do have a small issue with this
patch.
> @@ -69,14 +82,19 @@ TRACE_EVENT(virtio_transport_alloc_pkt,
> __entry->type = type;
> __entry->op = op;
> __entry->flags = flags;
> + __entry->msg_len = msg_len;
> + __entry->msg_cnt = msg_cnt;
> ),
> - TP_printk("%u:%u -> %u:%u len=%u type=%s op=%s flags=%#x",
> + TP_printk("%u:%u -> %u:%u len=%u type=%s op=%s flags=%#x "
> + "msg_len=%u msg_cnt=%u",
It's considered poor formatting to split strings like the above. This is
one of the exceptions for the 80 character limit. Do not break strings just
to keep it within 80 characters.
-- Steve
> __entry->src_cid, __entry->src_port,
> __entry->dst_cid, __entry->dst_port,
> __entry->len,
> show_type(__entry->type),
> show_op(__entry->op),
> - __entry->flags)
> + __entry->flags,
> + __entry->msg_len,
> + __entry->msg_cnt)
> );
next prev parent reply other threads:[~2021-03-02 23:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 5:33 [RFC PATCH v5 00/19] virtio/vsock: introduce SOCK_SEQPACKET support Arseny Krasnov
2021-02-18 5:36 ` [RFC PATCH v5 01/19] af_vsock: update functions for connectible socket Arseny Krasnov
2021-02-22 10:50 ` Stefano Garzarella
2021-02-22 10:58 ` Arseny Krasnov
2021-02-22 11:09 ` Stefano Garzarella
2021-02-18 5:36 ` [RFC PATCH v5 02/19] af_vsock: separate wait data loop Arseny Krasnov
2021-02-22 11:29 ` Stefano Garzarella
2021-02-25 14:24 ` Jorgen Hansen
2021-02-25 17:01 ` Arseny Krasnov
2021-02-18 5:36 ` [RFC PATCH v5 03/19] af_vsock: separate receive " Arseny Krasnov
2021-02-22 11:43 ` Stefano Garzarella
2021-02-18 5:37 ` [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop Arseny Krasnov
2021-02-22 11:53 ` Stefano Garzarella
2021-02-25 16:27 ` Jorgen Hansen
2021-02-25 17:00 ` Arseny Krasnov
2021-02-18 5:37 ` [RFC PATCH v5 05/19] af_vsock: separate wait space loop Arseny Krasnov
2021-02-22 12:06 ` Stefano Garzarella
2021-02-18 5:38 ` [RFC PATCH v5 06/19] af_vsock: implement send logic for SEQPACKET Arseny Krasnov
2021-02-18 5:38 ` [RFC PATCH v5 07/19] af_vsock: rest of SEQPACKET support Arseny Krasnov
2021-02-22 14:12 ` Stefano Garzarella
2021-02-18 5:38 ` [RFC PATCH v5 08/19] af_vsock: update comments for stream sockets Arseny Krasnov
2021-02-22 14:18 ` Stefano Garzarella
2021-02-18 5:39 ` [RFC PATCH v5 09/19] virtio/vsock: set packet's type in send Arseny Krasnov
2021-02-23 13:42 ` Stefano Garzarella
2021-02-18 5:39 ` [RFC PATCH v5 10/19] virtio/vsock: simplify credit update function API Arseny Krasnov
2021-02-23 13:49 ` Stefano Garzarella
2021-02-18 5:39 ` [RFC PATCH v5 11/19] virtio/vsock: dequeue callback for SOCK_SEQPACKET Arseny Krasnov
2021-02-23 14:15 ` Stefano Garzarella
2021-02-23 14:17 ` Michael S. Tsirkin
2021-02-24 5:07 ` Arseny Krasnov
2021-02-24 6:41 ` Michael S. Tsirkin
2021-02-24 8:31 ` Stefano Garzarella
2021-02-27 8:58 ` Arseny Krasnov
2021-02-18 5:39 ` [RFC PATCH v5 12/19] virtio/vsock: fetch length for SEQPACKET record Arseny Krasnov
2021-02-18 5:40 ` [RFC PATCH v5 13/19] virtio/vsock: add SEQPACKET receive logic Arseny Krasnov
2021-02-18 5:40 ` [RFC PATCH v5 14/19] virtio/vsock: rest of SOCK_SEQPACKET support Arseny Krasnov
2021-02-18 5:40 ` [RFC PATCH v5 15/19] virtio/vsock: setup SEQPACKET ops for transport Arseny Krasnov
2021-02-18 5:41 ` [RFC PATCH v5 16/19] vhost/vsock: " Arseny Krasnov
2021-02-18 5:41 ` [RFC PATCH v5 17/19] vsock/loopback: " Arseny Krasnov
2021-02-18 5:42 ` [RFC PATCH v5 18/19] vsock_test: add SOCK_SEQPACKET tests Arseny Krasnov
2021-02-18 5:42 ` [RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET Arseny Krasnov
2021-03-02 22:25 ` Steven Rostedt [this message]
2021-03-03 10:42 ` Arseny Krasnov
2021-02-22 14:23 ` [RFC PATCH v5 00/19] virtio/vsock: introduce SOCK_SEQPACKET support Stefano Garzarella
2021-02-23 14:50 ` Stefano Garzarella
2021-02-24 4:29 ` Arseny Krasnov
2021-02-24 8:23 ` Stefano Garzarella
2021-02-24 8:28 ` Arseny Krasnov
2021-02-24 8:35 ` Stefano Garzarella
2021-02-24 8:36 ` Arseny Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302172542.605b3795@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andraprs@amazon.com \
--cc=arseny.krasnov@kaspersky.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jhansen@vmware.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nslusarek@gmx.net \
--cc=oxffffaa@gmail.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=stsp2@yandex.ru \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).