From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D2F4C433E0 for ; Tue, 2 Mar 2021 22:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 140B4614A7 for ; Tue, 2 Mar 2021 22:10:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2359528AbhCBWAl (ORCPT ); Tue, 2 Mar 2021 17:00:41 -0500 Received: from relay-b03.edpnet.be ([212.71.1.220]:46092 "EHLO relay-b03.edpnet.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1835430AbhCBTGz (ORCPT ); Tue, 2 Mar 2021 14:06:55 -0500 X-ASG-Debug-ID: 1614710693-15c4356e4c23060001-xx1T2L Received: from zotac.vandijck-laurijssen.be (94.105.105.240.dyn.edpnet.net [94.105.105.240]) by relay-b03.edpnet.be with ESMTP id b4Gey686mZx8ui2U; Tue, 02 Mar 2021 19:44:53 +0100 (CET) X-Barracuda-Envelope-From: dev.kurt@vandijck-laurijssen.be X-Barracuda-Effective-Source-IP: 94.105.105.240.dyn.edpnet.net[94.105.105.240] X-Barracuda-Apparent-Source-IP: 94.105.105.240 Received: from x1.vandijck-laurijssen.be (x1.vandijck-laurijssen.be [IPv6:fd01::1a1d:eaff:fe02:d339]) by zotac.vandijck-laurijssen.be (Postfix) with ESMTPSA id 3D62612A739F; Tue, 2 Mar 2021 19:44:53 +0100 (CET) Date: Tue, 2 Mar 2021 19:44:51 +0100 From: Kurt Van Dijck To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Federico Vaga , Alexander Stein , "David S. Miller" , Jakub Kicinski , Marc Kleine-Budde , Oliver Hartkopp , Vincent Mailhol , Wolfgang Grandegger , YueHaibing , Zhang Qilong , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 3/6] can: c_can: fix control interface used by c_can_do_tx Message-ID: <20210302184451.GC26930@x1.vandijck-laurijssen.be> X-ASG-Orig-Subj: Re: [PATCH v3 3/6] can: c_can: fix control interface used by c_can_do_tx Mail-Followup-To: Dario Binacchi , linux-kernel@vger.kernel.org, Federico Vaga , Alexander Stein , "David S. Miller" , Jakub Kicinski , Marc Kleine-Budde , Oliver Hartkopp , Vincent Mailhol , Wolfgang Grandegger , YueHaibing , Zhang Qilong , linux-can@vger.kernel.org, netdev@vger.kernel.org References: <20210228103856.4089-1-dariobin@libero.it> <20210228103856.4089-4-dariobin@libero.it> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210228103856.4089-4-dariobin@libero.it> User-Agent: Mutt/1.5.22 (2013-10-16) X-Barracuda-Connect: 94.105.105.240.dyn.edpnet.net[94.105.105.240] X-Barracuda-Start-Time: 1614710693 X-Barracuda-URL: https://212.71.1.220:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at edpnet.be X-Barracuda-Scan-Msg-Size: 1116 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=7.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.88269 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 Feb 2021 11:38:52 +0100, Dario Binacchi wrote: > According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use > IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX). > > Signed-off-by: Dario Binacchi > --- > > (no changes since v1) > > drivers/net/can/c_can/c_can.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c > index dbcc1c1c92d6..69526c3a671c 100644 > --- a/drivers/net/can/c_can/c_can.c > +++ b/drivers/net/can/c_can/c_can.c > @@ -732,7 +732,7 @@ static void c_can_do_tx(struct net_device *dev) > idx--; > pend &= ~(1 << idx); > obj = idx + C_CAN_MSG_OBJ_TX_FIRST; > - c_can_inval_tx_object(dev, IF_RX, obj); > + c_can_inval_tx_object(dev, IF_TX, obj); Right. I had a similar effort last year to increase the reception throughput, but I ended with some sporadic strange tx echo problems. This fix may have fixed my problem as wel. > can_get_echo_skb(dev, idx, NULL); > bytes += priv->dlc[idx]; > pkts++; > -- > 2.17.1 >