* [PATCH] arm64: dts: renesas: falcon: Add GP LEDs
@ 2021-03-04 16:53 Kieran Bingham
2021-03-05 14:10 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Kieran Bingham @ 2021-03-04 16:53 UTC (permalink / raw)
To: Geert Uytterhoeven, linux-renesas-soc, devicetree, linux-kernel
Cc: Kieran Bingham
Three general purpose LEDs are provided on the Falcon CPU board.
Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
These LEDs are arranged in a block of four LEDs on the board itself, but
the fourth LED is as yet unidentified.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
index 5617b81dd7dc..a18f84128fe1 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
@@ -20,6 +20,20 @@ aliases {
chosen {
stdout-path = "serial0:115200n8";
};
+
+ leds {
+ compatible = "gpio-leds";
+
+ led1 {
+ gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
+ };
+ led2 {
+ gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+ };
+ led3 {
+ gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
+ };
+ };
};
&rwdt {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: renesas: falcon: Add GP LEDs
2021-03-04 16:53 [PATCH] arm64: dts: renesas: falcon: Add GP LEDs Kieran Bingham
@ 2021-03-05 14:10 ` Geert Uytterhoeven
2021-03-05 14:15 ` Kieran Bingham
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-03-05 14:10 UTC (permalink / raw)
To: Kieran Bingham
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Kieran,
On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> Three general purpose LEDs are provided on the Falcon CPU board.
>
> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
> These LEDs are arranged in a block of four LEDs on the board itself, but
> the fourth LED is as yet unidentified.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
I believe the LEDs are on the CPU board, so they belong in
r8a779a0-falcon-cpu.dtsi instead?
> @@ -20,6 +20,20 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led1 {
> + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
Any need for other properties from
Documentation/devicetree/bindings/leds/common.yaml, like
color = <LED_COLOR_ID_GREEN>?
> + };
> + led2 {
> + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
> + };
> + led3 {
> + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
> + };
> + };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: renesas: falcon: Add GP LEDs
2021-03-05 14:10 ` Geert Uytterhoeven
@ 2021-03-05 14:15 ` Kieran Bingham
0 siblings, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-03-05 14:15 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On 05/03/2021 14:10, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
>> Three general purpose LEDs are provided on the Falcon CPU board.
>>
>> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
>> These LEDs are arranged in a block of four LEDs on the board itself, but
>> the fourth LED is as yet unidentified.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
>
> I believe the LEDs are on the CPU board, so they belong in
> r8a779a0-falcon-cpu.dtsi instead?
Yes, I hadn't quite grasped the layouts of this new board yet.
Sorry - I'll move it.
>
>> @@ -20,6 +20,20 @@ aliases {
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + led1 {
>> + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
>
> Any need for other properties from
> Documentation/devicetree/bindings/leds/common.yaml, like
> color = <LED_COLOR_ID_GREEN>?
Oh, I wasn't aware of those. But indeed the LED is green, so it seems
appropriate.
I'll test it out, and see if I can make it glow red (jokes).
>
>> + };
>> + led2 {
>> + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
>> + };
>> + led3 {
>> + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
>> + };
>> + };
>> };
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-05 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 16:53 [PATCH] arm64: dts: renesas: falcon: Add GP LEDs Kieran Bingham
2021-03-05 14:10 ` Geert Uytterhoeven
2021-03-05 14:15 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).