From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH tip/core/rcu 02/12] timer: Report ignored local enqueue in nohz mode
Date: Thu, 4 Mar 2021 12:06:24 -0800 [thread overview]
Message-ID: <20210304200624.GU2696@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <a1bac9f6-cc67-943d-0f88-aad2f2b46bd7@intel.com>
On Thu, Mar 04, 2021 at 12:58:54PM +0100, Rafael J. Wysocki wrote:
> On 3/4/2021 1:23 AM, paulmck@kernel.org wrote:
> > From: Frederic Weisbecker <frederic@kernel.org>
> >
> > Enqueuing a local timer after the tick has been stopped will result in
> > the timer being ignored until the next random interrupt.
> >
> > Perform sanity checks to report these situations.
> >
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar<mingo@kernel.org>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Applied, thank you!
Thanx, Paul
> > ---
> > kernel/sched/core.c | 24 +++++++++++++++++++++++-
> > 1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index ca2bb62..4822371 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -674,6 +674,26 @@ int get_nohz_timer_target(void)
> > return cpu;
> > }
> > +static void wake_idle_assert_possible(void)
> > +{
> > +#ifdef CONFIG_SCHED_DEBUG
> > + /* Timers are re-evaluated after idle IRQs */
> > + if (in_hardirq())
> > + return;
> > + /*
> > + * Same as hardirqs, assuming they are executing
> > + * on IRQ tail. Ksoftirqd shouldn't reach here
> > + * as the timer base wouldn't be idle. And inline
> > + * softirq processing after a call to local_bh_enable()
> > + * within idle loop sound too fun to be considered here.
> > + */
> > + if (in_serving_softirq())
> > + return;
> > +
> > + WARN_ON_ONCE("Late timer enqueue may be ignored\n");
> > +#endif
> > +}
> > +
> > /*
> > * When add_timer_on() enqueues a timer into the timer wheel of an
> > * idle CPU then this timer might expire before the next timer event
> > @@ -688,8 +708,10 @@ static void wake_up_idle_cpu(int cpu)
> > {
> > struct rq *rq = cpu_rq(cpu);
> > - if (cpu == smp_processor_id())
> > + if (cpu == smp_processor_id()) {
> > + wake_idle_assert_possible();
> > return;
> > + }
> > if (set_nr_and_not_polling(rq->idle))
> > smp_send_reschedule(cpu);
>
>
next prev parent reply other threads:[~2021-03-04 20:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 0:22 [PATCH tip/core/rcu 0/12] NOCB updates for v5.13 Paul E. McKenney
2021-03-04 0:23 ` [PATCH tip/core/rcu 01/12] rcu/nocb: Detect unsafe checks for offloaded rdp paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 02/12] timer: Report ignored local enqueue in nohz mode paulmck
2021-03-04 11:58 ` Rafael J. Wysocki
2021-03-04 20:06 ` Paul E. McKenney [this message]
2021-03-04 0:23 ` [PATCH tip/core/rcu 03/12] rcu/nocb: Comment the reason behind BH disablement on batch processing paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 04/12] rcu/nocb: Forbid NOCB toggling on offline CPUs paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 05/12] rcu/nocb: Avoid confusing double write of rdp->nocb_cb_sleep paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 06/12] rcu/nocb: Only (re-)initialize segcblist when needed on CPU up paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 07/12] rcu/nocb: Rename nocb_gp_update_state to nocb_gp_update_state_deoffloading paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 08/12] rcu: Make nocb_nobypass_lim_per_jiffy static paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 09/12] rcu/nocb: Fix missed nocb_timer requeue paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 10/12] rcu/nocb: Disable bypass when CPU isn't completely offloaded paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 11/12] rcu/nocb: Remove stale comment above rcu_segcblist_offload() paulmck
2021-03-04 0:23 ` [PATCH tip/core/rcu 12/12] rcu/nocb: Move trace_rcu_nocb_wake() calls outside nocb_lock when possible paulmck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304200624.GU2696@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=fweisbec@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).