From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Justin Forbes <jforbes@redhat.com>,
Ondrej Mosnacek <omosnace@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>,
Miroslav Benes <mbenes@suse.cz>,
David Laight <David.Laight@aculab.com>,
Jessica Yu <jeyu@kernel.org>
Subject: Re: [PATCH RFC] kbuild: Prevent compiler mismatch with external modules
Date: Fri, 5 Mar 2021 13:24:51 -0600 [thread overview]
Message-ID: <20210305192451.xx6bm7t24amutukg@treble> (raw)
In-Reply-To: <CAK7LNARHoTnZ3gAvHgnYB4n-wYuboxC10A6zURh1ODGhxWd2yA@mail.gmail.com>
On Sat, Mar 06, 2021 at 01:28:22AM +0900, Masahiro Yamada wrote:
> > +orig_name := $(if $(CONFIG_CC_IS_GCC),GCC,CLANG)
> > +orig_minor := $(shell expr $(if $(CONFIG_CC_IS_GCC),$(CONFIG_GCC_VERSION),$(CONFIG_CLANG_VERSION)) / 100)
> > +cur_namever := $(shell $(srctree)/scripts/cc-version.sh $(CC))
> > +cur_name := $(word 1,$(cur_namever))
> > +cur_minor := $(shell expr $(word 2,$(cur_namever)) / 100)
>
> These are still calculated by 'make M=... clean' or 'make M=... help'.
> Using '=' assignment solves it, but the code is still ugly.
>
>
> I attached my alternative implementation.
Thanks for the attached patch, yours looks much cleaner. Looks like it
warns on *any* mismatch, rather than just a major.minor mismatch. But
that's ok with me.
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
prev parent reply other threads:[~2021-03-05 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 20:08 [PATCH RFC] kbuild: Prevent compiler mismatch with external modules Josh Poimboeuf
2021-01-28 20:24 ` Linus Torvalds
2021-01-28 20:52 ` Josh Poimboeuf
2021-01-28 21:03 ` Linus Torvalds
2021-01-28 21:23 ` Linus Torvalds
2021-01-28 21:34 ` Josh Poimboeuf
2021-01-28 21:45 ` Linus Torvalds
2021-01-28 22:08 ` Josh Poimboeuf
2021-01-28 23:17 ` Masahiro Yamada
2021-02-01 21:13 ` Josh Poimboeuf
2021-03-05 16:28 ` Masahiro Yamada
2021-03-05 19:24 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305192451.xx6bm7t24amutukg@treble \
--to=jpoimboe@redhat.com \
--cc=David.Laight@aculab.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jeyu@kernel.org \
--cc=jforbes@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=michal.lkml@markovi.net \
--cc=omosnace@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).