From: Rob Herring <robh@kernel.org>
To: Liu Ying <victor.liu@nxp.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org,
a.hajda@samsung.com, narmstrong@baylibre.com,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@siol.net, kishon@ti.com, vkoul@kernel.org
Subject: Re: [PATCH v4 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding
Date: Fri, 5 Mar 2021 16:42:27 -0600 [thread overview]
Message-ID: <20210305224227.GA772562@robh.at.kernel.org> (raw)
In-Reply-To: <1613619715-28785-9-git-send-email-victor.liu@nxp.com>
On Thu, Feb 18, 2021 at 11:41:49AM +0800, Liu Ying wrote:
> This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI).
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v3->v4:
> * Add 'fsl,sc-resource' property. (Rob)
>
> v2->v3:
> * Drop 'fsl,syscon' property. (Rob)
> * Mention the CSR module controls PXL2DPI.
>
> v1->v2:
> * Use graph schema. (Laurent)
>
> .../display/bridge/fsl,imx8qxp-pxl2dpi.yaml | 108 +++++++++++++++++++++
> 1 file changed, 108 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> new file mode 100644
> index 00000000..e4e77fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> @@ -0,0 +1,108 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/fsl,imx8qxp-pxl2dpi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX8qxp Pixel Link to Display Pixel Interface
> +
> +maintainers:
> + - Liu Ying <victor.liu@nxp.com>
> +
> +description: |
> + The Freescale i.MX8qxp Pixel Link to Display Pixel Interface(PXL2DPI)
> + interfaces the pixel link 36-bit data output and the DSI controller’s
> + MIPI-DPI 24-bit data input, and inputs of LVDS Display Bridge(LDB) module
> + used in LVDS mode, to remap the pixel color codings between those modules.
> + This module is purely combinatorial.
> +
> + The i.MX8qxp PXL2DPI is controlled by Control and Status Registers(CSR) module.
> + The CSR module, as a system controller, contains the PXL2DPI's configuration
> + register.
So this node should be a child of the CSR. Ideally, this schema is also
referenced from the CSR's schema (and if that doesn't exist, it should
be there first).
> +
> +properties:
> + compatible:
> + const: fsl,imx8qxp-pxl2dpi
> +
> + fsl,sc-resource:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: The SCU resource ID associated with this PXL2DPI instance.
> +
> + power-domains:
> + maxItems: 1
> +
> + fsl,companion-pxl2dpi:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: |
> + A phandle which points to companion PXL2DPI which is used by downstream
> + LVDS Display Bridge(LDB) in split mode.
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: The PXL2DPI input port node from pixel link.
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: The PXL2DPI output port node to downstream bridge.
> +
> + required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - fsl,sc-resource
> + - power-domains
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/firmware/imx/rsrc.h>
> + pxl2dpi {
> + compatible = "fsl,imx8qxp-pxl2dpi";
> + fsl,sc-resource = <IMX_SC_R_MIPI_0>;
> + power-domains = <&pd IMX_SC_R_MIPI_0>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + mipi_lvds_0_pxl2dpi_dc_pixel_link0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&dc_pixel_link0_mipi_lvds_0_pxl2dpi>;
> + };
> +
> + mipi_lvds_0_pxl2dpi_dc_pixel_link1: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&dc_pixel_link1_mipi_lvds_0_pxl2dpi>;
> + };
> + };
> +
> + port@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> +
> + mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&mipi_lvds_0_ldb_ch0_mipi_lvds_0_pxl2dpi>;
> + };
> +
> + mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch1: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&mipi_lvds_0_ldb_ch1_mipi_lvds_0_pxl2dpi>;
> + };
> + };
> + };
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-03-05 22:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 3:41 [PATCH v4 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs Liu Ying
2021-02-18 3:41 ` [PATCH v4 01/14] phy: Add LVDS configuration options Liu Ying
2021-02-26 11:52 ` Robert Foss
2021-02-18 3:41 ` [PATCH v4 02/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner Liu Ying
2021-02-26 11:59 ` Robert Foss
2021-02-18 3:41 ` [PATCH v4 03/14] media: docs: " Liu Ying
2021-02-26 12:44 ` Robert Foss
2021-02-18 3:41 ` [PATCH v4 04/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding Liu Ying
2021-02-18 3:41 ` [PATCH v4 05/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support Liu Ying
2021-02-26 13:07 ` Robert Foss
2021-03-01 9:05 ` Liu Ying
2021-03-01 10:56 ` Robert Foss
2021-03-02 1:36 ` Liu Ying
2021-02-18 3:41 ` [PATCH v4 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding Liu Ying
2021-02-18 3:41 ` [PATCH v4 07/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support Liu Ying
2021-03-02 13:53 ` Robert Foss
2021-03-03 6:59 ` Liu Ying
2021-02-18 3:41 ` [PATCH v4 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding Liu Ying
2021-03-05 22:42 ` Rob Herring [this message]
2021-03-08 9:52 ` Liu Ying
2021-02-18 3:41 ` [PATCH v4 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support Liu Ying
2021-02-18 3:41 ` [PATCH v4 10/14] drm/bridge: imx: Add LDB driver helper support Liu Ying
2021-03-02 14:22 ` Robert Foss
2021-03-03 7:21 ` Liu Ying
2021-03-03 15:34 ` Robert Foss
2021-03-04 3:27 ` Liu Ying
2021-03-08 10:10 ` Liu Ying
2021-02-18 3:41 ` [PATCH v4 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding Liu Ying
2021-02-18 3:41 ` [PATCH v4 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp Liu Ying
2021-02-18 3:41 ` [PATCH v4 13/14] drm/bridge: imx: Add LDB support for i.MX8qm Liu Ying
2021-02-18 3:41 ` [PATCH v4 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305224227.GA772562@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=victor.liu@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).