From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC78C43331 for ; Sat, 6 Mar 2021 02:00:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 261FC64E56 for ; Sat, 6 Mar 2021 02:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbhCFB7p (ORCPT ); Fri, 5 Mar 2021 20:59:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbhCFB71 (ORCPT ); Fri, 5 Mar 2021 20:59:27 -0500 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04631C061760 for ; Fri, 5 Mar 2021 17:59:27 -0800 (PST) Received: by mail-qv1-xf49.google.com with SMTP id m9so2915347qvu.11 for ; Fri, 05 Mar 2021 17:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=aLMlOWEZttp+WzQHkudkX6mdG2AM7wgPUhrApJPjk7c=; b=MQNx28BQ0KGA9ZFHN5O9mEIrlXkZw6u5GB8aVkvdAfBoezRb7G00sOAzUvFfnl0AGU 3U0xryA9xi+u1COvzxPRLHq+aQ3XroNyAwa3ZkfZI2pJ5iGTbO0o6VvqWJGqQjqtnj/h RgJzvIkY99FUGW18LxpV6RInOW+XLYWcwRgKShk6A3DuJfhNIAImA78K4z8xVChILnHS l8R99CmR/yejjFyn1WyIqg4L/EyEUBqaDnmjNEvz5AY615N1iRz9qwVt8WYULKKmIW4g En30wfpx1aM+ZzIEdQ7bHfbXpgpawSf1x+nCEjh5p4MllbJVfZeRLkdg5EeUkJRaOxA8 F3ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=aLMlOWEZttp+WzQHkudkX6mdG2AM7wgPUhrApJPjk7c=; b=QF9B4zJTQf91c9AOYujOaB/Lfc8DFcidUnxXslkjMpEw3Iwabn0RfRKQmekMk6sH5t kjGalzefXuk/MfUIC5S8hwJa2hrbTB5/LDi8U1tlrhgwxBbsyMkYwoQrt7WXe7PXDNXD GIJiSmVuJ58CiPCuh1xWQ2AWTO0lGn0yGfqjcsXvSAhVc/ZgK0bLbZ46vcPZ6mawczw6 XEEyCxLNOj5LvfoYpYuP6LqHUoix0/NYgMVfHhvTy/8qqEu1Qy5kwp2OiiwMo1DH8FwN tcZ66cx9bAoOx8YSEY3qwisV+86/0MrvbV4TFlsI4UtG+E6jAm5hRdwrbnvZl45v+BWS AHeg== X-Gm-Message-State: AOAM532DT+AshJsF4b9tpFCK0bKqbzN285snJ8zeyubUXBCxk3XsQqkG Znr0wGCTZ4k08f0SDg5bediuSyXrOVo= X-Google-Smtp-Source: ABdhPJwcpw78iVfnFmNDXyD/mD0kLqfEQl4B4rcpnMaO6YIKKkhIT+/hDSqgKvEINd/iCAZrgdEV6P+jAsM= Sender: "seanjc via sendgmr" X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:f:10:fc04:f9df:1efb:bf0c]) (user=seanjc job=sendgmr) by 2002:a0c:c248:: with SMTP id w8mr11883236qvh.58.1614995966156; Fri, 05 Mar 2021 17:59:26 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 5 Mar 2021 17:58:55 -0800 In-Reply-To: <20210306015905.186698-1-seanjc@google.com> Message-Id: <20210306015905.186698-5-seanjc@google.com> Mime-Version: 1.0 References: <20210306015905.186698-1-seanjc@google.com> X-Mailer: git-send-email 2.30.1.766.gb4fecdf3b7-goog Subject: [PATCH v4 04/14] KVM: x86: Do not advertise SME, VM_PAGE_FLUSH, or unknown features From: Sean Christopherson To: Paolo Bonzini , Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Tom Lendacky , Brijesh Singh Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a reverse-CPUID entry for the memory encryption word, 0x8000001F.EAX, and use it to override the supported CPUID flags reported to userspace. Masking the reported CPUID flags avoids over-reporting KVM support, e.g. without the mask a SEV-SNP capable CPU may incorrectly advertise SNP support to userspace. Explicitly omit SME and VM_PAGE_FLUSH, which are used by KVM, but not exposed to the guest, e.g. guest access to related MSRs will fault. Continue advertising SEV and SEV-ES, which guests of the associated type may expect to see present, as well as SME_COHERENT, which lets the guest know it can skip CLFLUSH operations. Cc: Tom Lendacky Cc: Brijesh Singh Signed-off-by: Sean Christopherson --- arch/x86/kvm/cpuid.c | 6 ++++++ arch/x86/kvm/cpuid.h | 1 + 2 files changed, 7 insertions(+) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 6bd2f8b830e4..45745c6c2161 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -514,6 +514,10 @@ void kvm_set_cpu_caps(void) */ kvm_cpu_cap_mask(CPUID_8000_000A_EDX, 0); + kvm_cpu_cap_mask(CPUID_8000_001F_EAX, + 0 /* SME */ | F(SEV) | 0 /* VM_PAGE_FLUSH */ | F(SEV_ES) | + F(SME_COHERENT)); + kvm_cpu_cap_mask(CPUID_C000_0001_EDX, F(XSTORE) | F(XSTORE_EN) | F(XCRYPT) | F(XCRYPT_EN) | F(ACE2) | F(ACE2_EN) | F(PHE) | F(PHE_EN) | @@ -871,6 +875,8 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function) case 0x8000001F: if (!boot_cpu_has(X86_FEATURE_SEV)) entry->eax = entry->ebx = entry->ecx = entry->edx = 0; + else + cpuid_entry_override(entry, CPUID_8000_001F_EAX); break; /*Add support for Centaur's CPUID instruction*/ case 0xC0000000: diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h index 2a0c5064497f..b3042ac6b5dc 100644 --- a/arch/x86/kvm/cpuid.h +++ b/arch/x86/kvm/cpuid.h @@ -80,6 +80,7 @@ static const struct cpuid_reg reverse_cpuid[] = { [CPUID_8000_0007_EBX] = {0x80000007, 0, CPUID_EBX}, [CPUID_7_EDX] = { 7, 0, CPUID_EDX}, [CPUID_7_1_EAX] = { 7, 1, CPUID_EAX}, + [CPUID_8000_001F_EAX] = {0x8000001f, 1, CPUID_EAX}, }; /* -- 2.30.1.766.gb4fecdf3b7-goog