From: Lee Jones <lee.jones@linaro.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Hans de Goede <hdegoede@redhat.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mfd: arizona: Make some symbols static
Date: Mon, 8 Mar 2021 13:52:47 +0000 [thread overview]
Message-ID: <20210308135247.GG4931@dell> (raw)
In-Reply-To: <20210210075626.1096193-1-weiyongjun1@huawei.com>
On Wed, 10 Feb 2021, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mfd/arizona-spi.c:28:31: warning:
> symbol 'reset_gpios' was not declared. Should it be static?
> drivers/mfd/arizona-spi.c:29:31: warning:
> symbol 'ldoena_gpios' was not declared. Should it be static?
>
> Those symbols are not used outside of arizona-spi.c, so this
> commit marks them static.
>
> Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mfd/arizona-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-03-08 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 7:56 [PATCH -next] mfd: arizona: Make some symbols static Wei Yongjun
2021-02-10 8:52 ` Hans de Goede
2021-02-11 10:06 ` Charles Keepax
2021-03-08 13:52 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308135247.GG4931@dell \
--to=lee.jones@linaro.org \
--cc=hdegoede@redhat.com \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).