From: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
To: <maz@kernel.org>, Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Cc: <daniel@thingy.jp>, <jason@lakedaemon.net>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<tglx@linutronix.de>, <yj.chiang@mediatek.com>
Subject: Re: [PATCH] irqchip/irq-mst: Support polarity configuration
Date: Mon, 8 Mar 2021 22:31:10 +0800 [thread overview]
Message-ID: <20210308143109.24644-1-mark-pk.tsai@mediatek.com> (raw)
In-Reply-To: <01b1c85119619c2418908a2fdabfb5dc@kernel.org>
From: Marc Zyngier <maz@kernel.org>
>On 2021-03-08 03:01, Mark-PK Tsai wrote:
>> From: Marc Zyngier <maz@kernel.org>
>>
>>> >
>>> > Support irq polarity configuration and save and restore the config
>>> > when system suspend and resume.
>>> >
>>> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
>>> > ---
>>> > drivers/irqchip/irq-mst-intc.c | 87 ++++++++++++++++++++++++++++++++--
>>> > 1 file changed, 84 insertions(+), 3 deletions(-)
>>> >
>>> > diff --git a/drivers/irqchip/irq-mst-intc.c b/drivers/irqchip/irq-mst-intc.c
>>> > index 143657b0cf28..979a4d55bcb1 100644
>>> > --- a/drivers/irqchip/irq-mst-intc.c
>>> > +++ b/drivers/irqchip/irq-mst-intc.c
>>> > @@ -13,15 +13,25 @@
>>> > #include <linux/of_irq.h>
>>> > #include <linux/slab.h>
>>> > #include <linux/spinlock.h>
>>> > +#include <linux/syscore_ops.h>
>>> >
>>> > -#define INTC_MASK 0x0
>>> > -#define INTC_EOI 0x20
>>> > +#define INTC_MASK 0x0
>>> > +#define INTC_REV_POLARITY 0x10
>>> > +#define INTC_EOI 0x20
>>> > +
>>> > +#ifdef CONFIG_PM_SLEEP
>>> > +static LIST_HEAD(mst_intc_list);
>>> > +#endif
>>> >
>>> > struct mst_intc_chip_data {
>>> > raw_spinlock_t lock;
>>> > unsigned int irq_start, nr_irqs;
>>> > void __iomem *base;
>>> > bool no_eoi;
>>> > +#ifdef CONFIG_PM_SLEEP
>>> > + struct list_head entry;
>>> > + u16 saved_polarity_conf[DIV_ROUND_UP(64, 16)];
>>>
>>> Where is this 64 coming from?
>>
>> The maximum number of interrupts a mst-intc supports is 64 in
>> Mstar and Mediatek SoCs now.
>> So I just use the maximum number of interrupts here.
>
>Then please use a named constant instead of a magic number.
>
Okay, I will update in patch v3.
prev parent reply other threads:[~2021-03-08 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:09 [PATCH] irqchip/irq-mst: Support polarity configuration Mark-PK Tsai
2021-03-06 17:06 ` Daniel Palmer
2021-03-06 18:28 ` Marc Zyngier
2021-03-08 2:42 ` Mark-PK Tsai (蔡沛剛)
2021-03-08 13:06 ` Daniel Palmer
2021-03-06 18:36 ` Marc Zyngier
2021-03-08 3:01 ` Mark-PK Tsai
2021-03-08 9:09 ` Marc Zyngier
2021-03-08 14:31 ` Mark-PK Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308143109.24644-1-mark-pk.tsai@mediatek.com \
--to=mark-pk.tsai@mediatek.com \
--cc=daniel@thingy.jp \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).