From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D9CFC4332B for ; Mon, 8 Mar 2021 20:39:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF92B64F09 for ; Mon, 8 Mar 2021 20:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbhCHUjG (ORCPT ); Mon, 8 Mar 2021 15:39:06 -0500 Received: from mail-io1-f53.google.com ([209.85.166.53]:45658 "EHLO mail-io1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhCHUir (ORCPT ); Mon, 8 Mar 2021 15:38:47 -0500 Received: by mail-io1-f53.google.com with SMTP id a7so11406204iok.12; Mon, 08 Mar 2021 12:38:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9lLfeCs1Tc8ddEaiXHzDtmEpQP9gGHowCs7DuxfnmRE=; b=V49zdQtIBvLb6HwUxPEQD22SVJN5av5W81Q9px9ylJFglJV6RRwil7zSg4hHTkWO0S oznzqb2kTi6QWySFgrLqot3EDays8lTCq1gusJOXGm5TjcKi/76IHpML1L/sw+8n05bq P1ZQQKtpRy8aIY375TXOx6n5fR0sAqPGbSryKCJIjyF/NeTBjqab54o2SciARXOxeVWT 2uLJyz8bg9fBqm93dsw0D53y3KtxVx+srr+XxBlOdKHTjdG/Cv10jkBLLLsidibAlwey ngw6vRjin6R65JbAfdlyP0HSiXPMHk6gosC+jBRUtRhfJqzibSDrzlrLcOzFJQqa6PuN 2n6w== X-Gm-Message-State: AOAM532eOZ+p4EpVEYatuiCq2X/WpB5ejqUzgRn6C1CRMp0JO59P4jta 9iARogE+ffYNHBHQ6tFzZQ== X-Google-Smtp-Source: ABdhPJz6/b0HXPf5UbrLJ8rHp/ABrKIy46sXafa7ZkfydealL7GIC6LpxZTvxSGmls2DzSoW84uFgw== X-Received: by 2002:a02:cc1a:: with SMTP id n26mr25539390jap.21.1615235926457; Mon, 08 Mar 2021 12:38:46 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id h128sm6553100ioa.32.2021.03.08.12.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 12:38:45 -0800 (PST) Received: (nullmailer pid 2920550 invoked by uid 1000); Mon, 08 Mar 2021 20:38:41 -0000 Date: Mon, 8 Mar 2021 13:38:41 -0700 From: Rob Herring To: Hector Martin Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH v3 06/27] dt-bindings: timer: arm,arch_timer: Add interrupt-names support Message-ID: <20210308203841.GA2906683@robh.at.kernel.org> References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-7-marcan@marcan.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304213902.83903-7-marcan@marcan.st> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 06:38:41AM +0900, Hector Martin wrote: > Not all platforms provide the same set of timers/interrupts, and Linux > only needs one (plus kvm/guest ones); some platforms are working around > this by using dummy fake interrupts. Implementing interrupt-names allows > the devicetree to specify an arbitrary set of available interrupts, so > the timer code can pick the right one. > > This also adds the hyp-virt timer/interrupt, which was previously not > expressed in the fixed 4-interrupt form. > > Signed-off-by: Hector Martin > --- > .../devicetree/bindings/timer/arm,arch_timer.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > index 2c75105c1398..ebe9b0bebe41 100644 > --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > @@ -34,11 +34,25 @@ properties: > - arm,armv8-timer > > interrupts: > + minItems: 1 > + maxItems: 5 > items: > - description: secure timer irq > - description: non-secure timer irq > - description: virtual timer irq > - description: hypervisor timer irq > + - description: hypervisor virtual timer irq > + > + interrupt-names: > + minItems: 1 > + maxItems: 5 > + items: > + enum: > + - phys-secure > + - phys > + - virt > + - hyp-phys > + - hyp-virt phys-secure and hyp-phys is not very consistent. secure-phys or sec-phys instead? This allows any order which is not ideal (unfortunately json-schema doesn't have a way to define order with optional entries in the middle). How many possible combinations are there which make sense? If that's a reasonable number, I'd rather see them listed out. Rob